Patch: Linker needs to give feedback on failure

[riftdesign]

In the case that scan.php returns malformed data, Linker does nothing to respond. When the "Insert Web Link" icon is clicked, nothing happens nor is there a javascript error thrown. It would be beneficial to the developer to know what happened. It would be helpful for the user to know that something isn't working correctly.

[Niko <ns@…>]

godd idea, i will implement this next week...

[Niko <ns@…>]

Patch (#67 is allready applied)

Index: linker.js
===================================================================
--- linker.js   (Revision 54)
+++ linker.js   (Arbeitskopie)
@@ -315,7 +315,14 @@
     {
         //get files from backend
         HTMLArea._getback(linker.lConfig.backend,
-                          function(txt) { lDialog.files = eval(txt); lDialog._prepareDialog(); });
+                          function(txt) {
+                            try {
+                                lDialog.files = eval(txt);
+                            } catch(Error) {
+                                alert('Error loading '+linker.lConfig.backend+':\n'+Error.toString());
+                                lDialog.files = [ {url:'',title:Error.toString()} ];
+                            }
+                            lDialog._prepareDialog(); });
     }
     else if(linker.lConfig.files != null)
     {

...don't know whats best here, either we use the alert, or we just display the error-message in the tree (one line should be removed)

[niko]

commited this patch as changeset:57, additional info about syntax in wiki:Linker