Opened 12 years ago

Closed 12 years ago

#950 closed defect (fixed)

Relative _editor_url causes translation bug on ContextMenu

Reported by: htanaka Owned by: htanaka
Priority: normal Milestone: Version 1.0
Component: Plugin_ContextMenu Version: trunk
Severity: normal Keywords: ContextMenu translation
Cc:

Description

Xinha accepts _editor_url as relative url, but it causes a problem about translation on ContextMenu?. It's problem is complex with baseHref property. Only FireFox?.

condition:

  • _editor_url : relative e.g.) var _editor_url = "../../xinha/";
  • baseHref : not null e.g.) xinha_config.baseHref = "http://foo/bar/";

I think ...

Xinha._lc function don't consider user specified baseHref and Xinha._loadlang uses raw _editor_url valiable. This way will success on out of IFRAME as editor pane. But in editor pane, loading external file from url which starts with baseHref automatically.

Which way is the best choice?

  1. ContextMenu? process translation out of IFRAME.
  2. fix the _editor_url to absolute at first.
  3. Xinha._lc handle baseHref if it is not null.

Change History (4)

comment:1 Changed 12 years ago by ray

fix the _editor_url to absolute at first is in every case a good idea, as also skins do not work with relative _editor_url

comment:2 Changed 12 years ago by htanaka

  • Component changed from Documentation to Plugin_ContextMenu
  • Owner changed from akaEdge to gogo

Sorry. Component was Documentation.

comment:3 Changed 12 years ago by htanaka

  • Owner changed from gogo to htanaka

I have tried to fix by converting the _editor_url to absolute. Now this problem looks like solved. I shall upload it to svn after testing not to make a new bug.

comment:4 Changed 12 years ago by htanaka

  • Resolution set to fixed
  • Status changed from new to closed

fixed at rev [734]

Note: See TracTickets for help on using tickets.