Opened 7 years ago

Closed 6 years ago

#918 closed task (fixed)

watch for possible changes in Gecko paragraph insertion

Reported by: ray Owned by: gogo
Priority: normal Milestone:
Component: Xinha Core Version:
Severity: normal Keywords:
Cc:

Description

Are we going to keep this at all?

Change History (7)

comment:1 Changed 7 years ago by wymsy

I vote to drop it. Two choices is enough. In my cms, I switched from using 'best' to 'none' a while back because EnterParagraphs still has some bugs, and in my opinion, even though they work slightly differently, the browsers' built-in paragraph handling works more reliably.

comment:2 Changed 7 years ago by ray

What bugs do you mean? Though I don't understand this code at all, maybe there's something improvable?

comment:3 Changed 7 years ago by wymsy

It's hard to pin down exactly, but strange things sometimes happened when editing text inside a table, breaking the structure of the table (adding a column, say, when you enter a return). Switching to built-in mode eliminated those problems for me.

Hmmm.... I just did a quick test, and it appears that Firefox 2 changed its handling of returns to be more like IE. FF used to follow these rules, but now it looks like it enters a br tag with a return and a p tag with a shift-return. Needs more testing to be sure, but this could mean we don't need EnterParagraphs any more either?

comment:4 Changed 7 years ago by ray

Well, the behaviour of EnterParagraphs, which I like and 'd like to preserve, is the other way round: <p> without shift, <br /> with shift. Nevertheless I'd like to get rid of EnterParagraphs, it's so big and complex, that cannot be optimal

comment:5 Changed 7 years ago by ray

OK, I don't know what made me write the above. Just tested this a little bit and found it to work quite good given the cursor is already inside a <p>.

comment:6 Changed 7 years ago by wymsy

Oops, I reversed the tags in what I said. Shift-return gives the br tag.

comment:7 Changed 6 years ago by ray

  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from mozParaHandler dirty broken to watch for possible changes in Gecko paragraph insertion
  • Type changed from defect to task

rev [945]: remove it

Note: See TracTickets for help on using tickets.