Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#913 closed defect (fixed)

Select all in broken in mozilla

Reported by: ray Owned by: gogo
Priority: normal Milestone:
Component: Xinha Core Version:
Severity: normal Keywords:


The function to get the selection used to be Xinha.prototype._getSelection(), it's changed to Xinha.prototype.getSelection(), which breaks pretty everything

Change History (2)

comment:1 Changed 13 years ago by ray

  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from _getSelection broken to Select all in broken in mozilla

Sorry, I was clouded. It was only wrong scope in Gecko.prototype.onKeyPress() where this._getSelection() threw the error

fixed rev [676]

comment:2 Changed 13 years ago by gogo

Yep the old underscored methods will call the new non-underscored methods, see around the bottom of XinhaCore?.js for that (where the HTMLArea = Xinha is). It's just a name change to be a bit more consistent.

Note: See TracTickets for help on using tickets.