Cell merge broken

[guest]

Clicking on a single cell in the table and then clicking on the merge button will produce the following error in Firefox:

Error: cells has no properties Source File: xinha/plugins/TableOperations/table-operations.js Line: 652

this relates to:

var cells = rows[i]; for (var j = 0; j < cells.length; ++j) {

// j && (HTML += "&nbsp;"); var cell = cells[j]; HTML += cell.innerHTML;

(i j) && (cell.parentNode.removeChild(cell));

}

In Internet Explorer 6 this will produce a prompt to ask how many cells to merge. (This is also broken in IE7, see ticket #908).

This is using the files as of revision [673]

David G. Paul (jedi58)

[jedi58]

just noticed the block of code has a FIXME for Mozilla, so this can probably be closed - probably a ticket somewhere for it that I couldn't find

[ray]

rev [675]: catch the error and prompt the user to select more than one cell

I think better would be to disable the button in this case, though

[jedi58]

This is now broken in IE6, have checked against the demo page for Xinha Nightly too and is also broken there.

[guest]

Note: bug caused by the addition of the dialog box - no matter how many cells are selected it just asks to select some.

[ray]

jedi58: What is broken, please specify. I have changed only the non-IE block

guest: works for me

[ray]

#908 contains a propable fix for this

[wymsy]

changeset:800