Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#896 closed defect (fixed)

Missing ";" after HTMLArea.prototype._shortCuts breaks Xinha when compressed with no linebreaks

Reported by: mharrisonline Owned by: gogo
Priority: normal Milestone: Version 1.0
Component: Xinha Core Version:
Severity: normal Keywords:
Cc:

Description

There has to be a ; after HTMLArea.prototype._shortCuts, just before the beginning of HTMLArea.prototype.convertNode = function(el, newTagName). Otherwise, if you compress htmlarea.js with a JavaScript? compressor and allow it to remove line-feeds, Xinha won't load and you get an alert about a missing ";".

Change History (2)

comment:1 Changed 11 years ago by ray

  • Resolution set to fixed
  • Status changed from new to closed

fixd rev [625]

Btw, can you recommend a compressor to use?

comment:2 Changed 11 years ago by mharrisonline

There was a discussion about this at:

http://xinha.python-hosting.com/ticket/115

I like this one the best, it's very fast and won't break your script, because it just crunches:

http://www.codeproject.com/csharp/JSCompress.asp

Note: See TracTickets for help on using tickets.