Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#852 closed defect (fixed)

some patches for EFM

Reported by: ray Owned by: akaEdge
Priority: normal Milestone:
Component: Plugin_ImageManager Version:
Severity: normal Keywords: ExtendedFileManager plugin
Cc:

Description

Hi!

  1. If you dont't specify any margin, padding, or border the respective styles are inserted anyway with a value of 0px, which, first, blows up the code unnecessaryly and, second, may interfere with existing stylesheets
  1. Like the two new config variables for alt and title, I'd like to introduce even more options to grant the administrator more control over what a user can change

I think especially the last one is important regarding XHTML strict

  1. some UI tweaks
  • show max upload size (imo very important to let the user not run into the limit unknowingly)
  • display the mode in the title bar of the popup
  • made a new "constrain proportions unlocked" icon (ok, that a matter of taste :))

looks like this:
http://raimundmeyer.de/xinha/efm_screenshot.png

What do you think, shall I commit?

Change History (3)

comment:1 Changed 8 years ago by koto

Of course (these are great features, thanks!), just one note: make sure that you update the col/rowspans for the table when changing the number of rows to hide/show appropriate fields in the popup. The code is quite trick about that :(

comment:2 Changed 8 years ago by ray

  • Resolution set to fixed
  • Status changed from new to closed

Yes, quite tricky indeed.
Cut it down to $IMConfigimages_enable_styling? to toggle them altogether. That's what I was about anyway...
Next is, I'd like to change alignment to css, because, you know, deprecated etc. :)

comment:3 Changed 8 years ago by koto

  • Component changed from Documentation to Plugin_ImageManager

Commited a small color-pickers related bugfix - see changeset:576

Note: See TracTickets for help on using tickets.