Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#842 closed defect (fixed)

Patch to fix IE browser back button

Reported by: mharrisonline Owned by: gogo
Priority: high Milestone: Version 1.0
Component: Xinha Core Version: trunk
Severity: major Keywords: back, history
Cc:

Description

Currently in IE the back button is nearly useless after Xinha loads. Clicking back once deactivates the editor and throws a js error, the user cannot back out without "frenzied clicking of the back button."

This can be fixed by changing two identical lines in htmlarea.js.

Change the two incidences of:

this._doc.open();

to:

this._doc.open("text/html","replace");

The back button then takes only one click to return to the page that was loaded before the editor's page.

Change History (5)

comment:1 Changed 13 years ago by guest

I can only find one instance of this._doc.open(); in htmlarea.js. There is, however, an instance of doc.open(); (without this or the underscore). Did you mean that?

comment:2 Changed 13 years ago by guest

I've tried this and tested quickly in IE and FireFox?. Works very nicely (I changed both instances of this._doc.open() and doc.open() ). Also seems to stop the overpopulating of the backbutton history with edits that occurs with IE when using the FullPage? plugin.

comment:3 Changed 13 years ago by mharrisonline

Yes, you have to change both, sorry. It would be great if someone with developer access could commit this. At the very least IE users would be able to back out of the example page in the future.

comment:4 Changed 13 years ago by ray

  • Resolution set to fixed
  • Status changed from new to closed

Seems to work alright. Committed in [587]

comment:5 Changed 13 years ago by mharrisonline

Thanks, Ray.

Note: See TracTickets for help on using tickets.