Opened 13 years ago

Closed 13 years ago

#781 closed defect (fixed)

Xinha fails to load in IE when SuperClean is used

Reported by: fmatull@… Owned by: gogo
Priority: high Milestone:
Component: Plugin_SuperClean Version: trunk
Severity: normal Keywords:
Cc:

Description

Hi-

Great program. I downloaded the nightly download version on May 5, 2006. I followed the Newbie Guide instructions to the letter, but it wouldn't work.

After a lot of searching, etc. I finally found that the following was included on the Newbie Guide (http://xinha.python-hosting.com/wiki/NewbieGuide) for the my_config.js:

xinha_plugins = xinha_plugins ? xinha_plugins :
[

'CharacterMap?',
'ContextMenu?',
'FullScreen?',
'ListType?',
'SpellChecker?',
'Stylist',
'SuperClean?',
'TableOperations?'

];

It seems that SuperClean? was not defined. So when I took 'SuperClean?', off of this list, then it started working.

To save others a lot of time and frustration, you will probably want to change that or have SuperClean? defined.

--Frank

Attachments (1)

SuperClean.diff.txt (1.1 KB) - added by koto@… 13 years ago.
Bugfix for Superclean plugin

Download all attachments as: .zip

Change History (3)

comment:1 Changed 13 years ago by guest

  • Component changed from Documentation to Plugin_SuperClean
  • Owner changed from akaEdge to gogo
  • Priority changed from normal to high
  • Summary changed from Problem on your Newbie Guide to Xinha fails to load in IE when SuperClean is used
  • Version set to trunk

Xinha stops at registering SuperClean? plugin as it can be seen by setting:

xinha_config.showLoading = true;

I have traced down the problem to be in Javascript array syntax used in super-clean.js file. Looks like extra comma after the last property in object is causing some syntax error In Internet Explorer (Firefox doesn't care). Removing the comma after 'remove_fancy_quotes' line completely fixes the error.

I will attach a diff file with the bugfix.

It is possible that the error requires some additional conditions to show up (my Xinha used to work with Superclean some time ago, however both Xinha and the calling application changed much since last time I checked in IE), however the fix gets rid of the problem once for all.

Changed 13 years ago by koto@…

Bugfix for Superclean plugin

comment:2 Changed 13 years ago by koto

  • Resolution set to fixed
  • Status changed from new to closed

Commited the diff in changeset:522 . Please add a comment if this doesn't fix the bug.

Note: See TracTickets for help on using tickets.