Opened 12 years ago

Closed 8 years ago

#58 closed enhancement (fixed)

feature-request: additional settings for Linker-Plugin

Reported by: ns@… Owned by: gogo
Priority: normal Milestone: 0.96
Component: Plugin_Linker Version: trunk
Severity: normal Keywords:
Cc:

Description

Setting to define which type of link is allowed.

  • popup-window (i won't allow the user to open popups as it would break the design)
  • same window (not every page has frames)
  • email-link (ok, this one doesn't hurt - but it is not needed everywhere)

Currently the tree with the links comes from a 'backend' php-file. This is very nice if you use it to scan directories.
Wouldn't it make sense to have the avaliable links as config-variables?
(in my case this would be only about 10 links to the latest news on the site and 15 links to some content-sites)
It would require a lot of extra work if i have to do it using the backend-php-file.

...and my third suggestion:
couldn't be the tree right of the inputs?
in some cases i would mainly use the tree to select the file
but other users might enter an external link and won't need the tree at all!

discussion here:
http://xinha.gogo.co.nz/punbb/viewtopic.php?pid=281

Change History (6)

comment:1 Changed 12 years ago by Niko <ns@…>

i just submitted the 2. part of my feature-request as patch #66

comment:2 Changed 12 years ago by gogo

  • Milestone set to 2.0
  • Version set to trunk

comment:3 Changed 11 years ago by scott@…

I had a similiar need on something I'm working on. I did not want the user to select any target, I always wanted to force _blank.

In htmlarea.js (LastChangedRevision: 477), I added a config property:

this.defaultTargetValue = '';

Then, in the _createLink function I leveraged this property. I changed [original] line 3920:

f_target : '',

to

f_target : editor.config.defaultTargetValue,

Then in myConfig.js I set some config variables [for all my editors]

xinha_config.makeLinkShowsTarget = false;
xinha_config.defaultTargetValue = '_blank';

The first property makes sure that the user cannot choose a target and the second property is used when calling the popup to set the target value, so it is returned on the submit.

Hope this is useful.

  • Scott

comment:4 Changed 9 years ago by ray

  • Milestone changed from 2.0 to 0.96

comment:5 Changed 8 years ago by nicholasbs

Some of these requests have been implemented, e.g., getting the links from the config file instead of the backend (see #66), and turning off e-mail links (see #1299).

comment:6 Changed 8 years ago by nicholasbs

  • Resolution set to fixed
  • Status changed from new to closed

Changeset r1097 allows for configurable target types.

Note: See TracTickets for help on using tickets.