Ticket #546 (closed defect: wontfix)

Opened 8 years ago

Last modified 6 years ago

encoding error with special characters when inserting images in FF

Reported by: Ray Owned by: gogo
Priority: normal Milestone:
Component: Xinha Core Version:
Severity: major Keywords:
Cc:

Description

My page is encoded in iso-8895-1. Inserting an image, no matter if ImageManager or standard dialog, in Firefox 1.0.7 in the url e.g. ö is encoded to %C3%B6 (that would be UTF-8, I think) instead of %F6

Attachments

ImageManager.patch (99.1 kB) - added by Kim Steinhaug 8 years ago.
Fix as described
.2 (0 bytes) - added by anonymous 7 years ago.

Change History

Changed 8 years ago by Kim Steinhaug

I had a similar problem with another plugin which supports on PHP, it seems that since Xinha is running in UTF-8, data delivered to Xinha from external PHP needs to be UTF-8 encoded. I would think this could be the case here aswell.

Changed 8 years ago by Kim Steinhaug

Fix as described

Changed 8 years ago by Kim Steinhaug

I did some changes to fix what you mentioned, but I didnt commit it since I dont know if its really needed... Well, using characters like you are referring to, or æøå in Norwegian, is a bad idea in the first place.

The applied patch makes the PHP files work with UTF-8, and fixes the filename when it contains letter that might conflict with the UTF-8 javascript files and such, as described in your ticket.

Changed 7 years ago by anonymous

  • attachment .2 added

Changed 6 years ago by gogo

  • status changed from new to closed
  • resolution set to wontfix

Closing this as wontfix.

I am fairly sure that characters in a URL should be UTF-8 encoded? Using non-ascii characters in file names is risky at best. We always recommend using UTF-8 for *everything*. The patch was not usable (every line was diff'd!). This ticket is 2 years old and no other complaints.

Note: See TracTickets for help on using tickets.