Ticket #545 (closed enhancement: inactive)

Opened 8 years ago

Last modified 4 years ago

Code suggestion for disableToolbar exceptions

Reported by: benDOTsimkinsATintsoftDOTch Owned by: gogo
Priority: normal Milestone: Version 1.0
Component: Xinha Core Version: trunk
Severity: minor Keywords: disable toolbar exceptions
Cc:

Description

I note that the disableToolbar function has a parameter 'except', but it is not currently used (at least in htmlarea.js). Could I suggest the adding an extra config item and using it like so:?

//BEFORE
 if(typeof except == 'undefined')
  {
    except = [ ];
  }
//AFTER
 if(typeof except == 'undefined')
  {
    except = [ ];*/
    if(typeof this.config.AlwaysOnButtons== 'undefined')
      except = [ ];
    else
      except = this.config.AlwaysOnButtons;
  }

Change History

Changed 8 years ago by benDOTsimkinsATintsoftDOT.ch

make that:

//BEFORE
 if(typeof except == 'undefined')
  {
    except = [ ];
  }
//AFTER
 if(typeof except == 'undefined')
  {
    if(typeof this.config.AlwaysOnButtons== 'undefined')
      except = [ ];
    else
      except = this.config.AlwaysOnButtons;
  }

Changed 8 years ago by gogo

What buttons should be "always on" ever... why would the user need to set this?

Changed 8 years ago by gogo

  • status changed from new to closed
  • resolution set to invalid

I don't see the point in this one, and no reply, so closing.

Changed 7 years ago by benDOTsimkinsATintsoftDOT.ch

  • status changed from closed to reopened
  • resolution deleted

Sorry, once again, I haven't been back in a while. Answer 1) Well, in our case, there are several buttons, which relate to the particular context in which we use the editor (as a popup editor within a CMS) - for example, 'Open new content' or 'Unlink this content from zone'. Answer 2) Someone must have thought it might be useful at some point, otherwise the 'except' parameter wouldn't be there.

Changed 5 years ago by ray

  • severity changed from normal to minor
  • milestone set to Version 1.0

Changed 4 years ago by gogo

  • status changed from reopened to closed
  • resolution set to inactive

Inactive. Things have probably changed too much to look at this.

Note: See TracTickets for help on using tickets.