Opened 14 years ago

Closed 10 years ago

#545 closed enhancement (inactive)

Code suggestion for disableToolbar exceptions

Reported by: benDOTsimkinsATintsoftDOTch Owned by: gogo
Priority: normal Milestone: Version 1.0
Component: Xinha Core Version: trunk
Severity: minor Keywords: disable toolbar exceptions
Cc:

Description

I note that the disableToolbar function has a parameter 'except', but it is not currently used (at least in htmlarea.js). Could I suggest the adding an extra config item and using it like so:?

//BEFORE
 if(typeof except == 'undefined')
  {
    except = [ ];
  }
//AFTER
 if(typeof except == 'undefined')
  {
    except = [ ];*/
    if(typeof this.config.AlwaysOnButtons== 'undefined')
      except = [ ];
    else
      except = this.config.AlwaysOnButtons;
  }

Change History (6)

comment:1 Changed 14 years ago by benDOTsimkinsATintsoftDOT.ch

make that:

//BEFORE
 if(typeof except == 'undefined')
  {
    except = [ ];
  }
//AFTER
 if(typeof except == 'undefined')
  {
    if(typeof this.config.AlwaysOnButtons== 'undefined')
      except = [ ];
    else
      except = this.config.AlwaysOnButtons;
  }

comment:2 Changed 14 years ago by gogo

What buttons should be "always on" ever... why would the user need to set this?

comment:3 Changed 14 years ago by gogo

  • Resolution set to invalid
  • Status changed from new to closed

I don't see the point in this one, and no reply, so closing.

comment:4 Changed 14 years ago by benDOTsimkinsATintsoftDOT.ch

  • Resolution invalid deleted
  • Status changed from closed to reopened

Sorry, once again, I haven't been back in a while.
Answer 1) Well, in our case, there are several buttons, which relate to the particular context in which we use the editor (as a popup editor within a CMS) - for example, 'Open new content' or 'Unlink this content from zone'.
Answer 2) Someone must have thought it might be useful at some point, otherwise the 'except' parameter wouldn't be there.

comment:5 Changed 11 years ago by ray

  • Milestone set to Version 1.0
  • Severity changed from normal to minor

comment:6 Changed 10 years ago by gogo

  • Resolution set to inactive
  • Status changed from reopened to closed

Inactive. Things have probably changed too much to look at this.

Note: See TracTickets for help on using tickets.