Ticket #477 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Edit Tag plugin JavaScript error fixed

Reported by: mharrisonline Owned by: gogo
Priority: normal Milestone:
Component: Plugin_Other Version:
Severity: normal Keywords:
Cc:

Description

In edit_tag.html line 20:

  document.body.onkeypress = _CloseOnEsc;

was creating a javascript error when users attempted to type into the text area in IE and Firefox. The error appeared upon keypress.

Removing the line fixed the error and did not affect the plugin functionality.

Attachments

EditTag.zip (2.9 kB) - added by anonymous 8 years ago.

Change History

Changed 8 years ago by anonymous

Changed 8 years ago by mharrisonline

I uploaded a fixed version of the plugin.

Changed 8 years ago by gocher

The following Line and Function

  HTMLArea.addDom0Event(document.body, 'keypress', __dlg_close_on_esc);
...
function __dlg_close_on_esc(ev) {
  ev || (ev = window.event);
  if (ev.keyCode == 27) {
    window.close();
    return false;
  }
  return true;
};

in popups/popups.js function dlg_init(bottom) manages the keypress with keyCode==27 . In my opinion we could delete all local functions _CloseOnEsc () in every Plugin!

Changed 8 years ago by gocher

  • status changed from new to closed
  • resolution set to fixed

Fixed at Changeset 309

Note: See TracTickets for help on using tickets.