Opened 14 years ago

Closed 14 years ago

#477 closed defect (fixed)

Edit Tag plugin JavaScript error fixed

Reported by: mharrisonline Owned by: gogo
Priority: normal Milestone:
Component: Plugin_Other Version:
Severity: normal Keywords:
Cc:

Description

In edit_tag.html line 20:

  document.body.onkeypress = _CloseOnEsc;

was creating a javascript error when users attempted to type into the text area in IE and Firefox. The error appeared upon keypress.

Removing the line fixed the error and did not affect the plugin functionality.

Attachments (1)

EditTag.zip (2.9 KB) - added by anonymous 14 years ago.

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by anonymous

comment:1 Changed 14 years ago by mharrisonline

I uploaded a fixed version of the plugin.

comment:2 Changed 14 years ago by gocher

The following Line and Function

  HTMLArea.addDom0Event(document.body, 'keypress', __dlg_close_on_esc);
...
function __dlg_close_on_esc(ev) {
  ev || (ev = window.event);
  if (ev.keyCode == 27) {
    window.close();
    return false;
  }
  return true;
};

in popups/popups.js function dlg_init(bottom) manages the keypress with keyCode==27 .
In my opinion we could delete all local functions _CloseOnEsc () in every Plugin!

comment:3 Changed 14 years ago by gocher

  • Resolution set to fixed
  • Status changed from new to closed

Fixed at Changeset 309

Note: See TracTickets for help on using tickets.