Opened 14 years ago

Closed 14 years ago

#470 closed defect (fixed)

onclick and only7BitPrintablesInURLs

Reported by: niko Owned by: gogo
Priority: high Milestone: Version 1.0
Component: Xinha Core Version:
Severity: major Keywords: onclick linker only7BitPrintablesInURLs %20 Stylist classes
Cc:

Description

the new config.only7BitPrintablesInURLs introduced in changeset:264 (#167) causes problems in event-handlers.
For example the following HTML-code:

<a href="#" onclick="alert( 'foo')"

gets converted into

<a href="#" onclick="alert(%20'foo')"

this happens in getHTML line 4769, because in line 4742 there is a /on/.test(name)

if (typeof root[a.nodeName] != "undefined" && name != "href" && name != "src" && !/^on/.test(name)) {

why is this necessary? these this only7BitPrintableInURLs should be only used for URL's (href and src)

a fix would be to remove the on, gogo please give your comment :D

...this bug(?) causes the Popup-Window functions of the Linker-Plugin fail.

Change History (3)

comment:1 Changed 14 years ago by ray

  • Component changed from Plugin - Linker to Xinha Core
  • Keywords Stylist classes added

this also makes it impossible to us more than one class with stylist, because the classnames have to be divided by spaces in the class-attribute which also are replaced by %20

comment:2 Changed 14 years ago by niko

sorry, it was changeset:261

comment:3 Changed 14 years ago by niko

  • Resolution set to fixed
  • Status changed from new to closed

fixed in changeset:316

Note: See TracTickets for help on using tickets.