Opened 14 years ago

Closed 13 years ago

#431 closed defect (fixed)

Xinha fails to start under Deer Park Alpha 2

Reported by: simon@… Owned by: gogo
Priority: lowest Milestone:
Component: Plugin_HtmlTidy Version:
Severity: minor Keywords:
Cc: marshall@…

Description

On Deer Park Alpha 2, Xinha fails to register plugins, with the following message in the javascript: console

Error: CharacterMap? is not defined
Source File: http://localhost:8080/cms/xinha/htmlarea.js
Line: 5348

Which is the registerPlugin call of the following function:

HTMLArea.prototype.registerPlugins = function(plugin_names) {

if(plugin_names)
{

for(var i = 0; i < plugin_names.length; i++)
{

this.registerPlugin(eval(plugin_names[i]));

}

}

}

Attachments (1)

deerpark.patch (623 bytes) - added by mrskensington@… 14 years ago.
patch fixing deer park issue

Download all attachments as: .zip

Change History (14)

comment:1 Changed 14 years ago by anonymous

I've made a attempt to report this bug on bugzilla.mozilla.com as bug 301869. My understanding of exactly what goes on when a plugin is registered isn't very clear, so the bug report could certainly stand some clarification/correction. A few voices other than my own may also help convince them that the issue needs addressing (one way or another) BEFORE the next version of Firefox is released.

Since Xinha still works in Deer Park 1 and earlier, I'm thinking this is a Mozilla problem, and not a Xinha problem.

comment:2 Changed 14 years ago by gogo

I'd test in DPA2 myself, except that it has a nasty tendancy to lock up my X session solid, probably the old aynchronous X request problem.

I'm of the opinion that we just wait until there is at least a beta, or RC.

comment:3 Changed 14 years ago by mrskensington@…

Deer Park is now out in Beta 1 and this bug is still occuring.

I've looked into it some more and I've so far managed to narrow it down to Line 2118 of htmlarea.js...

var nuPlugins = HTMLArea.cloneObject(plugins);

after this line is run, alert(plugins) displays
"CharacterMap?, ContextMenu?, FullScreen?, ListType?, Linker, SpellChecker?, Stylist, SuperClean?, TableOperation?, ImageManager?" (i've added spaces to make it format better)

alert(nuPlugins) displays
"[object Object]"

the line after uses nuPlugins.length...
plugins.length is 10 and nuPlugins.length is undefined

so it looks like cloneObject is not working properly... I had a look at the code but didn't really understand what was going wrong (or even what it actually was supposed to do)... so I thought I would add this comment to aid in the investigation.

comment:4 Changed 14 years ago by chris at antiochwebhost dot com

I'm receiving the same problem with 'Deer Park' Beta 1 -- or rather, Mozilla Firefox v1.5 Beta 1 as it is now called.

Of course, you can comment out all plug-ins and take it upon yourself to detect user agent and pick a different configuration javascript to work around this bug -- but that's a work around I really don't want to resort to :(

comment:5 Changed 14 years ago by mrskensington@…

I've found the problem and will post a patch in a bit.

In HTMLArea.loadPlugins the value returned from cloning the plugins did not match the plugins.

The problem was in HTMLArea.cloneObject, it looks like the mozilla developers removed a space from the beginning of the Array constructor. This meant instead instead of returning 1 (which it used to do) it now returned 0. The fix is to change the == 1 to != -1.

There is another problem with xinha running under firefox 1.5 beta 1... the javascript console now comes up with...

Error: Unknown property 'filter'. Declaration dropped.
Source File: http://10.0.0.4/controlPanel/xinha/htmlarea.css
Line: 50

Error: Expected color but found 'FieldFace?'. Error in parsing value for property 'background'. Declaration dropped.
Source File: http://10.0.0.4/controlPanel/xinha/htmlarea.css
Line: 70

The first one is simple enough... it looks firefox is now compaining about I.E. specific css properties... not a huge deal, there is probably some way of hiding it from firefox though...

The other one I have no idea what was being attempted here... it could probably just be changed for an actual color...

Changed 14 years ago by mrskensington@…

patch fixing deer park issue

comment:6 Changed 14 years ago by chris at antiochwebhost dot com

Mr S. Kensington -- Thank you so much for fixing this so quickly - the patch works wonderfully =)

I also noticed the CSS errors ...

comment:7 Changed 14 years ago by anonymous

Possible to get a >=0 or != -1 fix checked into head for this? Bug# 301869 over at Mozilla has now been resolved invalid, and Firefox 1.5 beta 2 release is imminent

comment:8 Changed 14 years ago by marshall@…

  • Cc marshall@… added

*bump*

comment:9 Changed 13 years ago by 이소라

  • Component changed from Xinha Core to Plugin_HtmlTidy

100% 공짜 화상게임쇼!

이쁜여성과 몸캠하며 즐기는게임!

http://oh.ah.to/

http://oh.ah.to/

http://oh.ah.to/

다수의 이쁜여성과 자유로운 즉석 번개팅가능!

뜨거운채팅! ...매일매일...쿨하게 즐겨여

삭+제+번+호:sesii1
</a>

comment:10 Changed 13 years ago by mokhet

is this bug still open ? I have no trouble using last changeset with Firefox 1.5

comment:11 Changed 13 years ago by 황진아

공짜!여성과 즐기는 화상 채팅!
무료포인트증정

http://oh.ah.to/

http://oh.ah.to/

http://oh.ah.to/

1:1비밀대화방,은밀한 둘만의 만남

자유로운 즉석 번개팅가능!

삭+제+번+호:ssx77
</a>

comment:12 Changed 13 years ago by mokhet

  • Priority changed from normal to lowest
  • Severity changed from normal to minor

*bump*

Is this ticket still open ?

Deer Park Alpha 2 was an alpha browser and does not exist anymore and as stated 2 months ago I have no trouble with Firefox 1.5

So, do we still have an issue here or can we close this ticket as "invalid" ?

I'm changing priority and severity of this ticket until further notification.

comment:13 Changed 13 years ago by mokhet

  • Resolution set to fixed
  • Status changed from new to closed

see ticket #643 which is kinda a duplicated ticket.

Note: See TracTickets for help on using tickets.