Opened 14 years ago

Closed 9 years ago

#427 closed defect (invalid)

Stop using the align tag

Reported by: s0092563@… Owned by: gogo
Priority: normal Milestone: 0.97
Component: Xinha Core Version: trunk
Severity: normal Keywords:
Cc:

Description

The align property is now depreciated by wc3, however xinha still uses this for formatting how images and other elements are aligned. Is there any way that this could be done using css rules instead to create html which complies with wc3? I'm willing to work on it, but I will need some pointers on where to get started.

Change History (5)

comment:1 Changed 14 years ago by gogo

  • Component changed from Documentation to Xinha Core
  • Owner changed from akaEdge to gogo

Could be done, probably. For Images then the ImageManager? plugin (and others like it) is where it would be fixed, for tables, the TableOperations? plugin.

Still it's possible though that the browser is going to make the odd align tag on it's own. Xinha is only really intended for your typcal Tag Soup until browsers pick up thier act at least.

comment:2 Changed 11 years ago by guest

  • Milestone set to 0.96
  • Version set to trunk

I bundled many of these changes into some work I was doing on related xhtml issues, please see Ticket #1179.

Cheers!

-- Troy

comment:3 Changed 11 years ago by ray

The changes in #1179 do not target the produced HTML, but only the HTML used in dialogs, so that's not really related

comment:4 Changed 10 years ago by nicholasbs

  • Milestone changed from 0.96 to 0.97

comment:5 Changed 9 years ago by gogo

  • Resolution set to invalid
  • Status changed from new to closed

Inactive, closing.

For ImageManager? this would be an easy job, just in ImageManager?.js change where it sets img.align to be img.style.float (appropriately). I have not looked at TableOperations?.

However, note that HTML edited by Xinha often ends up inside emails, and inside email clients inline style declaration (style="float:left") is pretty unreliable, while the old html attributes like align are generally OK. So if there was to be a change, it needs to be configurable.

I'm inclined to say that maybe we need Xinha.Config.useEmailSuitableHTML = true|false in general (see also Xinha.Config.7bitclean or something like that from distant memory).

Note: See TracTickets for help on using tickets.