Opened 14 years ago

Closed 14 years ago

#412 closed defect (fixed)

Patch: HtmlTidy not functioning after changeset [270]

Reported by: didier Belot Owned by: gogo
Priority: normal Milestone: Version 1.0
Component: Plugin_HtmlTidy Version:
Severity: major Keywords:
Cc:

Description

In changing shorttag to full tag (changeset [270]), one was not correctly changed.

As stated in the php manual: http://fr.php.net/manual/en/language.basic-syntax.php

<?= expression ?> This is a shortcut for "<? echo expression ?>"

html-tidy-logic.php need to be patched as follow for functioning again:

--- xinha/plugins/HtmlTidy/html-tidy-logic.php	2005-07-24 20:51:53.000000000 +0200
+++ xinha/plugins/HtmlTidy/html-tidy-logic.php	2005-07-24 20:44:45.000000000 +0200
@@ -60,5 +60,5 @@
 	}
 ?>
 var ns="";
-<?php $jsMakeSrc; ?>
-editor.setHTML(ns);
+<?php echo $jsMakeSrc; ?>
+editor.setHTML(ns);

Change History (2)

comment:1 Changed 14 years ago by didier Belot

see #417 for improvements to HtmlTidy?

comment:2 Changed 14 years ago by niko

  • Resolution set to fixed
  • Status changed from new to closed

fixed this in changeset:289

Note: See TracTickets for help on using tickets.