Ticket #353 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Skins for plugins /popups too

Reported by: gocher Owned by: gogo
Priority: normal Milestone:
Component: Xinha Core Version:
Severity: normal Keywords: Skin
Cc:

Description

I want to insert some style informations for the plugins /popups in the skin.css!
For Example:

.dialog {
  background-color: #EEEEEE;
}
.dialog .title {
  background-image: url(button-background.png);
}  
.dialog .button{
  background-image: url(button-background.png);
}

Where is the place to put this few lines in?

if(editor.config.skin != "") {
  var head = document.getElementsByTagName("head")[0];
  var link = document.createElement("link");
  link.type = "text/css";
  link.href = _editor_url + 'skins/' + editor.config.skin + '/skin.css';
  link.rel = "stylesheet";
  head.appendChild(link);
} 

I think the right place is in popups\popup.js function dlg_init but how can I get the editor.config.skin value?

Change History

Changed 8 years ago by gocher

  • owner changed from akaEdge to gogo
  • component changed from Documentation to Xinha Core

Changed 8 years ago by gogo

Currently I don't think the various popups are going to be co-operative with skins (well, they are just not skinable).

I'd also advise not using that code you pasted ( if(editor.config.skin) ) because when I get around to implementing skin selection it will be as

_editor_skin

because it is a global setting relative to all editors on a page.

Changed 8 years ago by gocher

I changed editor.config.skin to _editor_skin and implemented the skin for popups in changeset 239!

I prepared the example skin's and the following plugins already works fine: EditTag, InsertMarquee, Equatation, Forms, InsertSmily?, CharacterMap, FullPage?, InsertAnchor, Abbreviation, QuickTag, Template, FindReplace.

Changed 8 years ago by gocher

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.