Opened 12 years ago

Closed 8 years ago

#326 closed enhancement (fixed)

make it possible to choose from different icon sets

Reported by: riftdesign Owned by: ray
Priority: normal Milestone: 0.96
Component: Xinha Core Version:
Severity: normal Keywords: icon skin theme
Cc:

Description

The icons I submitted on the forum could be used in the distrobution if you want. The links are on my post: http://xinha.gogo.co.nz/punbb/viewtopic.php?id=89

Attachments (1)

xinhaIconSet.zip (18.3 KB) - added by riftdesign 12 years ago.
here's the icons

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by riftdesign

here's the icons

comment:1 Changed 12 years ago by gocher

It would be nice to set iconsets depending on skins!

  • create a default skin with img folder (the old images)
  • create to any other skin an iconset like yours or copy the old

but then every plugin must have a skin directory for the images of the plugin

Is that possible or is there a better way?

comment:2 Changed 12 years ago by niko

we have to think about:

  • plugins have icons too - we would need the icons for the plugins in the skin-folder (or the other way around, skin-folders in the plugin)
  • we have to take care about #39

comment:3 Changed 12 years ago by gogo

  • Milestone changed from Version 1.0 to 2.0
  • Severity changed from normal to enhancement
  • Summary changed from Updated Icons to Have different icons per skin.

Committed the icons in changeset:264

having different icons per skin would be... troublesome. Perhaps for V2.0, I'll leave the ticket open but change the milestone.

comment:4 Changed 11 years ago by kimss

Plugins need icons to, but placing the skins inside the plugins folders would not be practical in the real world. A skin should be a folder which includes x images.

I would think that if its possible, a Xinha skin is defined and concists of x images. All the images existing in a skin will be used first, if it doesnt exist it will be loaded from the plugins folder.

This sounds to me that the skin directory will need an extra xml fil containing a list of all the images inside the skin and what plugin they belong to. Then the plugin must define the images it wants to use. This way we pick the skin image if it exist or the plugin image if the skin isnt updated.

It could be done much simpler also,
"Force skin", would mean that all images is supposed to be in the skin folder. Meaning that we get alot of missing images in the editor if the skin isnt updated, our resposibility would then be to have updated skins - which shouldnt be much of a problem really?

Or maby its easier to incorporate a skin structure inside the plugins aswell? For those who likes to strip down an installation it would be many directories to delete however and could be looked upon as very "timeconsuming". (I know its easy to search fir directories, so it can be done fast aswell).

Some ideas anyways; D

comment:5 Changed 9 years ago by ray

  • Milestone changed from 2.0 to 0.96

comment:6 Changed 8 years ago by ray

  • Owner changed from gogo to ray

I have done a patch to make this possible; I will commit this shortly

comment:7 Changed 8 years ago by ray

  • Summary changed from Have different icons per skin. to make it possible to choose from different icon sets

comment:8 Changed 8 years ago by ray

  • Resolution set to fixed
  • Status changed from new to closed

rev [1113]: there is now the posibility to define named icon sets that can be loaded by adding

_editor_icons = "nameoftheset";

to the document, or a skin can recommend a specific set via its XML file.

The set itself is define by an XML file that lists each icon that is replaced, including i18n

I have already included two sets, the classic Xinha icons (for the more conservative characters ;)) and the Crystal Open Office icons

Note: See TracTickets for help on using tickets.