Ticket #313 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Large number of "... unexpected or duplicate quote mark" warnings in font colour picker

Reported by: m.bryson@… Owned by: mokhet
Priority: normal Milestone:
Component: Xinha Core Version:
Severity: normal Keywords: HTML error?
Cc:

Description

I've been running some of the ff debugging tools and noticed 1500+ warnings on this page! Highlight some text & click the font colour link.

A lot of the errors are to do with incorrect quoting of all the TD params

[td bgcolor="#000000" onMouseOver=View('000000') onClick=Set('000000') height="10px" width="10px"]/td

might be better as

[td bgcolor="#000000" onMouseOver="View('000000')" onClick="Set('000000')" height="10px" width="10px"]/td

There are other errors as well though, I've run an HTML validator on the page but the output is a bit too long to upload as text here. If anyone would like a copy please email me.

Change History

Changed 8 years ago by mokhet

  • owner changed from gogo to mokhet

are some errors missing in the following list ?

  • missing DTD (looks like some HTML4.1 trans, but i think it's better to use at least <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">)
  • missing UTF8 encoding information (i think browsers will fallback to UTF8, but meta info should be present)
  • missing the ACTION parameter of the FORM
  • all the events should be in lowercase (onsubmit, onclick, onmouseover)
  • missing the double quotes around almost every parameters
  • width="10px" height="10px" is invalid (should be width="10" height="10")
  • td valign="center" is invalid (should be td valign="middle")

is there more errors to fix ?

Changed 8 years ago by mokhet

  • status changed from new to assigned

Changed 8 years ago by mokhet

The dtd wanted here is 

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

The strict version would require too many modifications in select_color.html

Changed 8 years ago by mokhet

  • status changed from assigned to closed
  • resolution set to fixed

fixed in changeset [214]

select_color.html is now valid HTML4.01 transitional

select_color.html will still not validate because no DTD can be used until ticket #318 is closed but if we add the DTD, the page is error free.

Note: See TracTickets for help on using tickets.