Ticket #265 (closed defect: duplicate)

Opened 8 years ago

Last modified 6 years ago

full page plugin meta tag patches

Reported by: aldug@… Owned by: gogo
Priority: high Milestone: Version 1.0
Component: Plugin_FullPage Version: trunk
Severity: major Keywords: patch
Cc:

Description

I have a patch I wrote against htmlarea 3rc3 which adds meta tags to the full page proporties. Where should I send these patches?

Attachments

full-page.diff (2.6 kB) - added by aldug@… 8 years ago.
full-page.2.diff (2.6 kB) - added by anonymous 8 years ago.
docprop.diff (0.9 kB) - added by aldug@… 8 years ago.

Change History

Changed 8 years ago by aldug@…

Changed 8 years ago by anonymous

Changed 8 years ago by aldug@…

Changed 8 years ago by aldug@…

actually, I think these patches were against rc1

Changed 8 years ago by anonymous

  • summary changed from upll page plugin meta tag patches to full page plugin meta tag patches

Changed 8 years ago by anonymous

Any word on getting these accepted?

Changed 8 years ago by gogo

  • keywords patch added
  • version set to trunk
  • severity changed from normal to enhancement
  • milestone set to Version 1.0

They will be looked at before V1.0, enhancements have low priority at the moment. Unless you want to apply them youself and help with more javascript development - email james@… if you do.

Changed 8 years ago by gocher

  • status changed from new to closed
  • resolution set to fixed

modified in changeset 248

Changed 8 years ago by mharrisonline

  • priority changed from normal to high
  • status changed from closed to reopened
  • resolution deleted
  • severity changed from enhancement to major

This change broke body attributes in Xinha in firefox with the full page plugin in . Body attributes began dissapearing from HTML files in full page config Xinha in firefox with changeset 177.

However, in firefox body attributes were still retained if the full page plugin was used. After changeset 248, the plugin no longer preserved the body attributes.

Changeset 177 broke body attributes in Xinha in firefox with htmlarea.js configured for full page. The full page plugin when used made attributes stay.

Changeset 248 broke the full page plugin in firefox by stopping it also from preserving body attributes.

This means that if background colors or images or other attributes are present in the body tag when Xinha is used in firefox, Xinha now strips the body tag down to <body>, corrupting content Xinha (and formerly HTMLArea3) was fully able to edit until changesets 177 and 248.

Changed 8 years ago by gocher

look at Ticket #459

Changed 6 years ago by ray

  • status changed from reopened to closed
  • resolution set to duplicate

duplicate of #459

Note: See TracTickets for help on using tickets.