Opened 13 years ago

Closed 13 years ago

#174 closed defect (fixed)

Table Properties dialog does not close

Reported by: muth@… Owned by: gogo
Priority: normal Milestone:
Component: Xinha Core Version:
Severity: normal Keywords:
Cc:

Description

Got the nightly build from 04/25/2005, tried on

Mozilla/5.0 (X11; U; Linux i686; de-DE; rv:1.7.6) Gecko/20050306 Firefox/1.0.1 (Debian package 1.0.1-2)

and

Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.7.5) Gecko/20050105 Debian/1.7.5-1

The Table Properties does not close on either OK or Cancel. The changed properties are not changed in the editor on "OK".

Change History (3)

comment:1 Changed 13 years ago by anonymous

Problem found: Diff from latest to nightly in table-operations.js:

-		dialog.addButtons("ok", "cancel");
+		dialog.addButtons("OK", "Cancel");

and in popupwin.js:

PopupWin.prototype.addButtons = function() {
	var self = this;
	var div = this.doc.createElement("div");
	this.content.appendChild(div);
	div.className = "buttons";
	for (var i = 0; i < arguments.length; ++i) {
		var btn = arguments[i];
		var button = this.doc.createElement("button");
		div.appendChild(button);
		button.innerHTML = HTMLArea._lc(btn, 'HTMLArea');
		switch (btn) {
		    case "ok":
			button.onclick = function() {
				self.callHandler();
				self.close();
				return false;
			};
			break;
		    case "cancel":
			button.onclick = function() {
				self.close();
				return false;
			};
			break;
		}
	}
};

I added

		[...]
		switch (btn) {
		    case "ok":
		    case "OK":
		[...]
		    case "cancel":
		    case "Cancel":
		[...]

Works now fine for me.

comment:2 Changed 13 years ago by muth@…

Last post was mine.

Found a better HotFix: change switch(btn) to switch(btn.toLowerCase())

Keep on your good work, Xinha rocks (but lacks a cool logo).

:)

comment:3 Changed 13 years ago by niko

  • Resolution set to fixed
  • Status changed from new to closed

commited in changeset:87

oops, thas was my fault :(
see changeset:81 (#154)

much thanks for your report and fix!

Note: See TracTickets for help on using tickets.