Opened 4 years ago

Last modified 4 years ago

#1609 assigned defect

Xinha does not work anymore in Firefox 22 AND Chrome 28

Reported by: guest Owned by: ejucovy
Priority: normal Milestone:
Component: Xinha Core Version: trunk
Severity: major Keywords:
Cc:

Description

Xinha does not work anymore in Firefox 22 AND Chrome 28

I get the Error: TypeError?: Illegal constructor

Change History (4)

comment:1 Changed 4 years ago by guest

line 3007: var obj = new plugin(this, args);

comment:2 Changed 4 years ago by guest

The error occurs in combination with the Plugin: CSS

comment:3 Changed 4 years ago by guest

I can confirm that this is an issue in Firefox 22.

I wasn't able to investigate very deeply, but it seems as though there's a conflict with using CSS as an object name. I tried changing the name of the plugin (at least temporarily) and it seems to work fine now.

Directory/file name changes:
plugins/CSS/ -> plugins/CSSDropdowns/
plugins/CSS/CSS.js -> plugins/CSSDropdowns/CSSDropdowns.js

Plugin changes:
function CSS( -> function CSSDropdowns(
CSS.prototype.* -> CSSDropdowns.prototype.*

Configuration changes:
'CSS' -> 'CSSDropdowns' in the xinha_plugins configuration section

comment:4 Changed 4 years ago by ejucovy

  • Owner changed from gogo to ejucovy
  • Status changed from new to assigned

Thanks, I can reproduce the issue and I think your solution is the right approach. It might be worth also adding some explicit checks for the "CSS" plugin name for backwards-compatibility. I'll commit this ASAP.

Note: See TracTickets for help on using tickets.