Opened 4 years ago

Last modified 4 years ago

#1560 reopened enhancement

TableOperations: define a dblclickList action for tables

Reported by: ejucovy Owned by:
Priority: normal Milestone: 0.97
Component: Plugins Version: trunk
Severity: normal Keywords:
Cc:

Description

The TableOperations plugin could define a dblclickList action for table (or maybe td, I'm not sure which would be better) which would open up its "edit table properties" dialog.

(Original discussion for this feature was at http://trac.xinha.org/ticket/1555#comment:7 and following comments)

Change History (3)

comment:1 Changed 4 years ago by ejucovy

  • Resolution set to fixed
  • Status changed from new to closed

r1280.

I registered the action for td, not table -- the dblclickList feature doesn't walk up the tree, it only looks at the nearest tag of the dblclick'ed spot. It's possible to *select* a tr, tbody or table, but I don't think it's possible to *click* any of those (because you're always going to be clicking on a specific point, which will be inside one of the cells) so td is the right thing to register for.

(Well, maybe it's possible to click elsewhere on a table with very large borders or padding?)

I'm not sure what will happen if the user registers a dblclickList action for td in his configuration -- one will clobber the other, but I'm not sure which will win. This isn't ideal, but I think it's good enough for now. (The alternative is putting in a lot of logic to detect whether any actions already exist for td, which still won't cover all cases.) In the future, maybe there can some way to fix this, but it seems like a bigger project that will need some thought.

comment:2 Changed 4 years ago by gogo

Handling <th> in the same way also would seem logical.

comment:3 Changed 4 years ago by ejucovy

  • Resolution fixed deleted
  • Status changed from closed to reopened

Good point. I'll reopen.

Note: See TracTickets for help on using tickets.