Opened 7 years ago

Closed 7 years ago

#1483 closed defect (fixed)

Equation plugin "Cancel" button does not work

Reported by: guest Owned by:
Priority: normal Milestone: 0.96
Component: Plugins Version: trunk
Severity: normal Keywords: equation, cancel, button
Cc:

Description

I only tested on Firefox 3.5.5, but the "Cancel" button does not work because the dialog passes a null value back and then the first thing that is done is to read it as an array.

The fix is simple. Add these two lines to the top of the Equation.prototype.insert method:

	if (typeof param == "undefined" || param == null)
		return;

I'm also interested in doing more fixes since we need the Equations to be of production quality in our project. Should I post other fixes as bug reports like this one? Or is there a way to access the repo?

Regards,
Niraj Bhawnani
Research Assistant
University of New South Wales

Change History (2)

comment:1 Changed 7 years ago by guest

On second thought, this code is sufficient:

	if (param == null)
		return;

comment:2 Changed 7 years ago by gogo

  • Resolution set to fixed
  • Status changed from new to closed

Thank you for your submission, this is committed in changeset:1255

[If you would like commit access, contact me - james at gogo dot co dot nz ]

Note: See TracTickets for help on using tickets.