Ticket #1340 (closed enhancement: duplicate)

Opened 4 years ago

Last modified 4 years ago

[SuperClean] should provide means to choose tidy preferences

Reported by: guest Owned by:
Priority: normal Milestone:
Component: Plugins Version: trunk
Severity: normal Keywords: SuperClean
Cc: rimas.kudelis@…

Description

Currently SuperClean uses hardcoded tidy configuration options, and provides no means to change them except by editing the plugin files.

Ideally, this should be configurable from the same place where Xinha itself is configured – using the xinha_config array.

Change History

Changed 4 years ago by douglas

  • status changed from new to closed
  • resolution set to duplicate

This is a duplicate of ticket #1220.

Changed 4 years ago by douglas

I should mention that #1220 is scheduled for the next release, so this is on schedule to be fixed.

Changed 4 years ago by gogo

changeset:1199 , ticket #1220

Note that the ticket above does not close this ticket, the options to tidy are still hard coded, the changeset just makes it possible to implement a changeset for this ticket if somebody wants to get around to it.

Hint

 xinha_config.SuperClean.tidy_args = { 'myarg':'myvalue' }

gets into source:trunk/plugins/SuperClean/tidy.php as $_REQUEST['myarg'] so a change to tidy.php to SECURELY pass in options to the tidy executable (or whatever) should be simple enough, just be sure you don't open up a security hole!

Note: See TracTickets for help on using tickets.