Opened 11 years ago

Closed 11 years ago

#1325 closed defect (invalid)

Iconsets don't work for plugin icons

Reported by: douglas Owned by: ray
Priority: normal Milestone: 0.96
Component: Xinha Core Version: trunk
Severity: normal Keywords: iconset
Cc: douglas

Description

The new iconset functionality doesn't work for assinging icons to a plugin.

Change History (2)

comment:1 Changed 11 years ago by douglas

r1115 Updates the Tango iconset to include an icon for the SmartReplace? plugin. This doesn't take effect because the iconset is parsed, but not kept with the editor to replace incoming icon registrations...

comment:2 Changed 11 years ago by ray

  • Resolution set to invalid
  • Status changed from new to closed

It works if you explicitly select "Tango" as _editor_icons. The iconset XML is parsed and applied after the plugins have registered their buttons.

But I think we should leave the default icons in the images folder and the respective definitions in the code. That way we save one loading and parsing pass.

Also people tend to like to throw away everything they see fit, so we have the iconsets folder as optional, like the plugins folder is optional and modules isn't.

Along the way: Could I - as the author of the plugin - ask for not replacing the SmartReplace? icon? Is there anything special you don't like about it? (Have you seen that I just recently crafted a new one to better fit with the Tango style?)

Note: See TracTickets for help on using tickets.