Opened 8 years ago

Closed 8 years ago

#1292 closed enhancement (fixed)

change naming scheme of plugin files

Reported by: ray Owned by: gogo
Priority: normal Milestone: 0.96
Component: Xinha Core Version: trunk
Severity: normal Keywords:
Cc:

Description

Why are the plugin files named as they are? In case anyone knows, plaese let me know ;) However I don't like it at all and I think it's a big obstacle for would be plugin authors. I once started writing a plugin tutorial and I just failed explaining the scheme. IMHO the files should be named like the folders and the functions and the name by which it is loaded. Problem of course is backward compatibility, because at the moment loading fails completely when a file is not found.

I have written a path that uses HEAD requests to test whether a file exists. Of cost this costs a few milliseconds, but I think this is affordable and has also the benefit of gracefully skipping plugins that are not found. A message is printed to the console in either case, plugin using the old scheme and plugin not found.

Additionally I there is a considerable speed increase, because I lowered the interval in which the plugin loading status is queried, so I have the hope that overall loading time at least with chached filesis reduced, in spite of the extra requests.

Change History (4)

comment:1 Changed 8 years ago by ray

committed rev [1059]: obiously existing filenames have to be changed if no one has objections against this patch

comment:2 Changed 8 years ago by ray

apparently this doesn't work well in Opera. I have spent hours to find out why, but I can't see anything. Somehow it seems to be a bug in opera. I'd say. Maybe the patch has to be reverted.

Still we have the possibility to simply (though not eleganty) try to loadback both URLs.

rev [1062] contains a slightly different version of the patch

comment:3 Changed 8 years ago by ray

rev [1063]: so, now it works in Opera, too. Plus, the HEAD request is used asynchronously, that ther is no additional time consumed if the file is correctly named

comment:4 Changed 8 years ago by ray

  • Resolution set to fixed
  • Status changed from new to closed

rev [1067]: renamed all plugin files.

Note: See TracTickets for help on using tickets.