Ticket #1283 (new defect)
New-dialogs version of TableOperations is incomplete
|Reported by:||nicholasbs||Owned by:|
I realized today that the version of the TableOperations plugin for new-dialogs is incomplete. Most notably, the settings from its various dialogs (e.g., Table Properties) do not get applied to the table.
I've looked into the code a bit and discovered at least one of the issues: the dialog is constructed dynamically in part using the InlineStyler? module. This means that when Xinha.Dialog.translateHtml creates its reverse ID index of all elements in the document, it does not actually get all of the form elements. This in turn means that dialog.hide() does not return values for some of the input elements, making it impossible for TableOperations to properly update the attributes.
Off the top of my head, I can think of a couple of ways to fix this:
1. Hard-code the dialog HTML instead of dynamically generating it
2. Add a method that updates Xinha.Dialog's reverse ID lookup index
I'm initially in favor of doing (2) but not strongly so, and I admit I haven't spent a lot of time thinking about this/looking at the code.
Thoughts? Ray, I believe you did the initial work on this plugin a while ago, how were you planning on tackling this?