Opened 11 years ago

Closed 11 years ago

#1264 closed enhancement (fixed)

Lightboxes should close when user presses ESC

Reported by: nicholasbs Owned by: nicholasbs
Priority: normal Milestone: 0.96
Component: User Interface Version: trunk
Severity: normal Keywords: new-dialogs
Cc:

Description (last modified by nicholasbs)

It's pretty standard that lightboxes (i.e., dialogs like the ones in the new-dialogs branch) close when the user presses the escape key. This should be a configurable option that can be set globally.

Change History (8)

comment:1 Changed 11 years ago by nicholasbs

  • Owner set to nicholasbs
  • Status changed from new to assigned

comment:2 Changed 11 years ago by nicholasbs

  • Description modified (diff)

Changeset r1019 adds a new option for this called closeOnEscape (off by default). This can be set either for individual dialogs or using a global config, e.g.,

xinha_config.dialogOptions['closeOnEscape'] = true

r1019 also disables modeless dialogs, as their implementation is currently incomplete and there are no plugins that use them. The current issues include:

  • new modeless dialogs can be inadvertently opened behind other dialogs
  • there's no visual indication of which modeless dialog is activated/has focus
  • closing a dialog does not cause the dialog behind it to gain focus
  • showing a dialog does not cause it to become the active dialog
  • you can type in a text field of a dialog even when it's not in the front, and doing so doesn't activate it

comment:3 Changed 11 years ago by nicholasbs

This code still needs to be tested on more browsers, particularly Internet Explorer.

comment:4 Changed 11 years ago by nicholasbs

To avoid confusion, r1020 pops up an alert that says modeless dialog support is incomplete should someone try to use one.

comment:5 Changed 11 years ago by ray

there are no plugins that use them

Actually Stylist and CharacterMap? use modeless dialogs and they work as expected

As I see it modeless dialogs don't require any activation or focus. They are "just there".

comment:6 Changed 11 years ago by ray

see my comment (19) at #1176

comment:7 Changed 11 years ago by ray

removed disabling of modelessness (didn't work anyway)

comment:8 Changed 11 years ago by nicholasbs

  • Resolution set to fixed
  • Status changed from assigned to closed

Closing since the fix from r1019 has now been tested in IE and Opera.

Note: See TracTickets for help on using tickets.