Opened 9 years ago

Closed 7 years ago

#1262 closed enhancement (fixed)

Feature-request: add additional path to sizeItDown method in fullscreen module

Reported by: guest Owned by: gogo
Priority: normal Milestone: 0.96
Component: Xinha Core Version: trunk
Severity: normal Keywords:
Cc: a.bogaart@…

Description

The current implementation of the sizeItDown method in the fullscreen module calls the Xinha.initSize() method to go back to 'normal' dimensions.
In my usecase the editor's size/resizing is controlled by a Xinha plugin that is connected to a clientside layout manager which uses the YUI library to provide a dynamic page layout. The initSize() method will do it's job correct if there is no resizing during fullscreen, but if fails to get the correct dimensions if there is.

For this I've written a patch that adds a 'restore' path to the sizeItDown method; before the editor goes into fullscreen, the editor's dimensions are stored in the fullscreen module. When we return from fullscreen, the previous dimensions are restored adding/substracting the difference between the current and the previous viewport.

The path is configured by property Xinha.config.fullScreenSizeDownMethod with default value 'initSize' and optional value 'restore'.

Attachments (1)

Xinha-SizeItDown.js.patch (2.8 KB) - added by guest 9 years ago.
Xinha Fullscreen module SizeItDown? patch

Download all attachments as: .zip

Change History (2)

Changed 9 years ago by guest

Xinha Fullscreen module SizeItDown? patch

comment:1 Changed 7 years ago by gogo

  • Resolution set to fixed
  • Status changed from new to closed

Thanks for the contribution, this is committed in changeset:1219

Note: See TracTickets for help on using tickets.