Opened 11 years ago

Closed 10 years ago

#1241 closed defect (wontfix)

[PATCH] new dialogs -- dialogs don't close on pressing enter/return

Reported by: guest Owned by:
Priority: normal Milestone: 0.96
Component: User Interface Version:
Severity: normal Keywords: new-dialogs patch
Cc:

Description

The new dialogs created using the system in ticket #1176 do not support pressing the enter/return key to close them as the old popup windows did. This forces the user to use the mouse to manually click the "OK" button.

Change History (4)

comment:1 Changed 11 years ago by guest

This can be easily handled by an individual plugin by attaching an onsubmit handler to its form:

  this.dialog.getElementById("inputs").onsubmit = function() {
    self.apply(); // function called when the user clicks the default button
    return false;
  }

comment:2 Changed 11 years ago by guest

See the Abbreviation plugin patch attached to #1176 for an example of a plugin that uses an onsubmit handler as suggested above.

comment:3 Changed 11 years ago by gogo

  • Keywords patch added
  • Summary changed from new dialogs -- dialogs don't close on pressing enter/return to [PATCH] new dialogs -- dialogs don't close on pressing enter/return

comment:4 Changed 10 years ago by nicholasbs

  • Resolution set to wontfix
  • Status changed from new to closed

Closing as wontfix since this should be decided on a plugin-by-plugin basis (and I was the one who originally submitted this request :D).

Note: See TracTickets for help on using tickets.