Ticket #121 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

ImageManager Plugin (nightly build) and short PHP tags

Reported by: the_sandking Owned by: gogo
Priority: normal Milestone: Version 1.0
Component: Xinha Core Version: trunk
Severity: normal Keywords: Plugin ImageManager
Cc:

Description

<?
<?= 
<? print

The above all bad PHP form (possibly lazy), and depending on whether or not APACHE is setup to parse XML/XHTML, any files that use PHP shorthand like the above will not function..

I have found almost 100 of these PHP short tags in the ImageManager plugin so far but appearantly not all of them, I am not quite yet at 100% functionality there. :)

The following are better, compatible, and more *correct* replacements.

<?php 
<?php echo

Thanks!

Attachments

ImageManager.patch (32.2 kB) - added by mokhet 8 years ago.
.2 (0 bytes) - added by anonymous 8 years ago.

Change History

Changed 8 years ago by gogo

  • version changed from yermo to 0.1

Please feel free to submit a patch to remove short tags from any php file, it shoudl be a simple enough regexp.

Changed 8 years ago by mokhet

think the attached patch fix them all

Changed 8 years ago by mokhet

Changed 8 years ago by gogo

  • version changed from 0.1 to trunk

Changed 8 years ago by anonymous

  • attachment .2 added

Changed 8 years ago by gogo

  • status changed from new to closed
  • resolution set to fixed

Fixed these in changeset:270

Note: See TracTickets for help on using tickets.