Ticket #1197 (closed defect: fixed)

Opened 7 months ago

Last modified 7 months ago

[Linker] Patch for files[i].length, IE shows bug in line 262

Reported by: guest Owned by:
Priority: normal Milestone: 0.95
Component: Plugins Version: trunk
Severity: major Keywords: Linker, length, Internet Explorer, IE
Cc: roman@…, guest

Description

On loading editor, IE shows bug in line 262, that length is empty or isn't object.

I think it's a line 423 in linker.js where is a test for array. I propose other condition for testing, instead of:

    else if(files[i].length)

do:

    else if(typeof files[i]=="object" && files[i] && typeof files[i].length==="number")

Cheers, romus

Attachments

linker.js (15.3 kB) - added by guest 7 months ago.
Patched linker.js [Linker Plugin]

Change History

Changed 7 months ago by guest

Patched linker.js [Linker Plugin]

Changed 7 months ago by ray

  • status changed from new to closed
  • resolution set to fixed
  • milestone changed from 0.96 to 0.95

rev [996]: I could not reproduce this error, could please check if this patch (I did it a bit simpler than you) fixes it?

Changed 7 months ago by guest

  • cc guest added
  • status changed from closed to reopened
  • resolution deleted

Thanks for replay. I've checked Your patch. There is other bug, now i've got something strange (in translation): 'udefined' is empty or isn't object.

I thing it's a matter of testing for array type (is an object but special, so test isn't simple).

This bug shows up in: IE 7.0.5730.13 (only with GoogleToolbar?, without any special changes, it's for testing only). Original bug shows up also on my clients PCs.

Cheers, romus

Changed 7 months ago by ray

  • status changed from reopened to closed
  • resolution set to fixed

rev [997]: still can't reproduce, and neither I understand why the simple checks don't work; but OK if it works better for you now

Note: See TracTickets for help on using tickets.