Ticket #1193 (closed defect: fixed)

Opened 2 years ago

Last modified 1 year ago

Stylist bug when formatting selected text

Reported by: guest Owned by:
Priority: normal Milestone: 0.96
Component: Plugins Version: trunk
Severity: major Keywords: confirmed
Cc: walder@…

Description

Hello Xinha developers.

I found a bug in the Stylist plugin:

Do the following to reproduce it

1. Select some Text 2. Select a CSS Style from Stylist and apply it 3. Select the Text again (same snippet as in step 1) but this time add add some more text) 4. Select the same CSS stlye as in step 2. apply it 5. Select the whole formatted text remove the CSS Style and the text which was newly added in step 3 vanishes.

Change History

Changed 2 years ago by gogo

  • keywords confirmed added
  • severity changed from normal to major

Confirmed FF3

Changed 1 year ago by nicholasbs

  • status changed from new to closed
  • resolution set to fixed

r1135 fixes this bug by 1) using el.hasChildNodes() instead of indexing into an array (whose contents might change), and 2) recursing down to ensure the styling is removed from child elements.

While doing this work I noticed that there are several other issues with Stylist, which I'll document in a new ticket.

Note: See TracTickets for help on using tickets.