Opened 11 years ago

Closed 11 years ago

#1179 closed enhancement (fixed)

minor html syntax changes

Reported by: guest Owned by:
Priority: normal Milestone: 0.95
Component: Xinha Core Version: trunk
Severity: minor Keywords:
Cc:

Description

I just imported xinha into eclipse and saw two little html issues, here's a patch.

Attachments (3)

minor_syntax.patch.txt (1.2 KB) - added by guest 11 years ago.
Minor html syntax patch on svn trunk
xhtml_warn_fixes.patch (8.9 KB) - added by guest 11 years ago.
Various XHTML fixes to warnings generated by eclipse.
lots_of_xhtml_fixes.patch (51.1 KB) - added by guest 11 years ago.
Lots more xhtml fixes, some deprecated elements like align, valign and target. Cumulative patch of the previous files.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by guest

Minor html syntax patch on svn trunk

comment:1 Changed 11 years ago by guest

Ok, I went a little syntax crazy. I went through the warnings in eclipse and found some more minor xhtml issues. Another file attached.

Changed 11 years ago by guest

Various XHTML fixes to warnings generated by eclipse.

comment:2 Changed 11 years ago by guest

  • Summary changed from Two minor html syntax changes to minor html syntax changes

comment:3 Changed 11 years ago by guest

Alright, I'm done for the night, I swear. I saw ticket #427 and thought that I could fix the align, valign and target tags pretty quickly. Large patch attached.

Changed 11 years ago by guest

Lots more xhtml fixes, some deprecated elements like align, valign and target. Cumulative patch of the previous files.

comment:4 Changed 11 years ago by ray

  • Component changed from HTML Output to Xinha Core
  • Milestone changed from 0.96 to 0.95
  • Resolution set to fixed
  • Status changed from new to closed
  • Type changed from defect to enhancement

rev [987]: Thanks for your work.

I didn't take over most of the target changes, for various reasons, including some targets refer to frames or belong to functionality provided by plugins and cannot simply be replaced by onclick/window open. Other instances are in HTML contexts that do not forbid the target attribute, so it makes no sense to replace it

Note: See TracTickets for help on using tickets.