Opened 11 years ago

Closed 11 years ago

#1175 closed defect (no action needed)

IE8 beta DomWalk broken/switch to TransformInnerHTML as default?

Reported by: ray Owned by:
Priority: normal Milestone: 0.96
Component: Browsers_InternetExplorer Version: trunk
Severity: major Keywords:
Cc:

Description

because getting node.attribute.length throws an "not implemented" error. This can only be a beta bug which we have to wait for being fixed. They can't mean this honestly!

Change History (5)

comment:1 Changed 11 years ago by ray

  • Summary changed from IE8 beta DomWalk broken to IE8 beta DomWalk broken/switch to TransformInnerHTML as default?

rev [980]: set IE8 to use only TransformInnerHTML. Personally, I've always been kind of fond of the old method, but mybe this is the time to switch over to TransformInnerHTML as default? Wymsy, is this "original Xinha"?

comment:2 Changed 11 years ago by wymsy

Not sure what you mean by "original Xinha", but ticket:253 documents the history. It was developed for Xinha specifically, if that's what you are asking.

comment:3 Changed 11 years ago by gogo

My opinion is that DOMWalk should remain the default, because it is the "proper" way to do the job.

Using InnerHTML and a crapload of regexps is fine for speed when it works, but pretty rudely incomprehensible when it comes time to fix it :-)

As for attributes.length being unimplemented in IE8 (taking ray's word on that, I don't have IE8) it can only be a bug in IE8, and I don't think worth looking at it further.

comment:4 Changed 11 years ago by gogo

See also #1250

comment:5 Changed 11 years ago by ray

  • Resolution set to no action needed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.