Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#1172 closed enhancement (fixed)

[LangMarks] make available languages configurable

Reported by: guest Owned by:
Priority: normal Milestone: 0.95
Component: Plugins Version: trunk
Severity: normal Keywords: LangMarks
Cc: rimas.kudelis@…

Description

Currently, to change the list of languages available in LangMarks plugin, one needs to edit lang-marks.js.

Instead, it should be configurable via Xinha.Config, just like many other plugins are.

Attachments (2)

LangMarks.diff (6.9 KB) - added by guest 7 years ago.
New patch. Takes care of CSS, and sets same class "haslang" for all spans it creates.
lang-marks-lang.diff (410 bytes) - added by guest 7 years ago.
Incremental patch

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by guest

  • Component changed from Xinha Core to Plugins
  • Owner gogo deleted

Changed 7 years ago by guest

New patch. Takes care of CSS, and sets same class "haslang" for all spans it creates.

comment:2 Changed 7 years ago by guest

With this new patch, the img/ subdirectory can be entirely removed from the plugin directory.

comment:3 Changed 7 years ago by guest

  • Summary changed from LangMarks plugin should be configurable through Xinha.Config to [patch] LangMarks plugin should be configurable through Xinha.Config

comment:4 Changed 7 years ago by ray

  • Milestone set to 0.96
  • Type changed from defect to enhancement

comment:5 Changed 7 years ago by guest

What is the process to get this checked-in?

comment:6 Changed 7 years ago by ray

  • Milestone changed from 0.96 to 0.95
  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from [patch] LangMarks plugin should be configurable through Xinha.Config to [LangMarks] make available languages configurable

rev [911]: cool idea generating the language sign with CSS. Of course this doesn't work with IE, but I think the plugin is way more usable now, so thats worth it.

comment:7 Changed 7 years ago by guest

Thank you. :) I stole the idea and from Mozilla's webpages. :)

Just for the record, it's rev [991] actually.

comment:8 Changed 7 years ago by guest

  • Resolution fixed deleted
  • Status changed from closed to reopened

Changed 7 years ago by guest

Incremental patch

comment:9 Changed 7 years ago by guest

Please apply lang-marks-lang.diff on top. You didn't have to capitalize [lang] in CSS, it should be lowercase (because the attribute is lowercase).

By the way, (the idea just hit me) would it be possible to use 'xml:lang' instead of 'lang', which is deprecated in xhtml? That would be a subject for a new ticket, I guess..

comment:10 Changed 7 years ago by ray

  • Resolution set to fixed
  • Status changed from reopened to closed

rev [995]: thanks

Currently your idea with xml:lang makes not much sense, as Xinha is has to work for both HTML and XHTML and I think it's better to have an attribute that's deprecated in the one dialect than one that doesn't even exist in the other. In the long run we should be able to switch doctypes globally, but that's surely stuff for another ticket...

comment:11 Changed 7 years ago by guest

I filed #1189 regarding xml:lang. Ray, if you're reading this, would you please take a look at the suggestion I made there?

comment:12 Changed 6 years ago by guest

Why isn't this available in the latest nightly?

Note: See TracTickets for help on using tickets.