Opened 9 years ago

Closed 7 years ago

#1093 closed enhancement (fixed)

[InsertSmiley] remove smiley gifs from trunk

Reported by: ray Owned by: gocher
Priority: low Milestone:
Component: Plugin_Smiley Version:
Severity: minor Keywords:
Cc:

Description

The smiley files are taking up really much space (I think around 500kb zipped, that half of the whole package). I'm sure a lot of users will be glad not to have down/upload them all the time, if we took them out of the distribution. Also they don't need versioning.

Change History (4)

comment:1 Changed 9 years ago by ray

  • Type changed from defect to enhancement

comment:2 Changed 9 years ago by ray

  • Resolution set to fixed
  • Status changed from new to closed

rev [904]:

  • removed 580 files
  • I will provide an archive to download as well as the single files on my server
  • added an option so set the URL to the smileys to an arbitrary folder, defaulting to my server so it still works out of the box. This makes it possible to locate the smileys outside the Xinha folder .
  • previously the files were referenced by counting up to a number hard-coded in the js file, making changes to the files hard to impossible. I changed this to a list-based approach where an implementor can use the list to supply arbitrary filenames
  • added an explanatory readme file

comment:3 Changed 9 years ago by gogo

  • Resolution fixed deleted
  • Status changed from closed to reopened

A better solution would be to leave them in the repos, but just strip from distribution files. I don't much like the idea of having stuff outside of the SVN, even if it doesn't "really" need to be version managed.

Similarly with all the number of plugins we have, eventually it's going to get to the point where people will want to download them separatly, but they certainly shouldn't be removed from the repos just to do that.

I think the smilies should be reinstated to the svn.

comment:4 Changed 7 years ago by gogo

  • Resolution set to fixed
  • Status changed from reopened to closed

changeset:1224 brings back a handful of Smileys, introduces a better configuration and easier way to add more smileys, and brings it into the new dialogs.

I couldn't figure out how to make the dialog auto-overflow properly though, so if they add a lot of Smileys, it's gonna get weird. Can somebody fix that?

Note: See TracTickets for help on using tickets.