Opened 10 years ago

Closed 10 years ago

#1026 closed defect (fixed)

Skins referenced with <link>-tags don't work anymore

Reported by: guest Owned by: gogo
Priority: normal Milestone:
Component: Xinha Core Version: trunk
Severity: major Keywords:
Cc:

Description

I was using 0.92beta with success.
With 0.93 or latest nightly build skins don't work anymore : the toolbar background and panel background stays in their default color.

Change History (7)

comment:1 Changed 10 years ago by gogo

Are you loading the stylesheet directly, or using

{{{_editor_skin='blue-look';]}}

(substitute whatever skin name). Whichever method you are using, Try the other one.

comment:2 Changed 10 years ago by gogo

(Should have previewed).

Are you loading the stylesheet directly, or using

_editor_skin='blue-look';

(substitute whatever skin name).
Whichever method you are using, Try the other one.

comment:3 Changed 10 years ago by wymsy

I ran into this, too. It's because the new method for loading stylesheets is not backwards compatible by default with the old way. The old way was with < link > tags, with the link for the skin placed after the main stylesheet. If you use the old method with 0.93, with no _editor_css and _editor_skin config parameters specified, the new method will always try to load Xinha.css again unless you set the id for the link tag to 'id="XinhaCoreDesign?". This will revert any css entries that were overridden in the skin.

The workaround is either to set the id as above, or switch to the new method. A permanent backwards-compatible fix would probably have to loop through all the link tags and check the hrefs before (re)loading Xinha.css.

A related problem I found is that you cannot use the skin to modify the style of the loading messages with 0.93, because the skin styles are loaded too late in the start-up sequence (after a bunch of plugins). That can be fixed by moving the block of code that loads the skin to immediately after the code that loads the main stylesheet.

comment:4 Changed 10 years ago by wymsy

  • Resolution set to fixed
  • Status changed from new to closed

Both problems fixed in changeset:826.

comment:5 Changed 10 years ago by guest

That's actually changeset:834 I think :)

comment:6 Changed 10 years ago by ray

  • Resolution fixed deleted
  • Status changed from closed to reopened

It's still not possible to define a skin using a static <link rel="stylesheet">. See http://xinha.gogo.co.nz/punbb/viewtopic.php?id=1070

comment:7 Changed 10 years ago by ray

  • Resolution set to fixed
  • Status changed from reopened to closed
  • Summary changed from Skins don't work anymore with 0.93 to Skins referenced with <link>-tags don't work anymore

fixed rev [878]: Xinha.css is now prepended before any stylesheets that are already defined thusly allow these to override the standard style rules

Note: See TracTickets for help on using tickets.