Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#1021 closed defect (fixed)

ExtendedFileManager masks ImageManager

Reported by: gogo Owned by: gogo
Priority: normal Milestone:
Component: Plugin_ImageManager Version: trunk
Severity: normal Keywords:


(Tracking ticket about to commit).

If you use the ExtendedFileManager plugin and the ImageManager plugin, if ExtendedFileManager is loaded after ImageManager it will mask ImageManager (make it not work), because they both override Xinha.prototype._insertImage.

Change to be commmitted will correct this so that is ExtendedFileManager is loaded after ImageManager then ImageManager will continue to be used for insertImage (and ExtendedFileManager will continue to be used for it's own button).

One day the two plugins should be merged into one which does all the same functions as both, ExtendedFileManager used to be like that originally I think but it didn't keep up with things added to ImageManager in the time before ExtendedFileManager came over to Xinha. I suspect the easiest way would be to add the missing features from ImageManager to ExtendedFileManager.

Change History (2)

comment:1 Changed 10 years ago by gogo

  • Resolution set to fixed
  • Status changed from new to closed

comment:2 Changed 10 years ago by koto

I am just browsing history logs for both plugins. When, back in June 2006 I modified EFM at it was introduced in Xinha SVN it was up to date with ImageManager functionality at that time (IIRC).

Current changesets are usually applied to both plugins by ray, so I guess it's OK to replace IM with EFM.

The only differences I can spot right now are:

  • [829] small bugfix
  • [831],[832] generic input field Image URL picking functionality
  • [833] small bugfix (Opera)

And there is this new IM configuration option 'show_full_options' - but in EFM there already are options accounting for it.

Could someone (ray?) confirm on this? Dropping ImageManager would simplify future changes as we would not be maintaining both plugins that perform identical tasks.

Note: See TracTickets for help on using tickets.