Opened 15 years ago

Closed 14 years ago

#102 closed defect (fixed)

Patch: Toggleborders is faulty with Mozilla

Reported by: anonymous Owned by: gogo
Priority: high Milestone:
Component: Xinha Core Version: 0.1
Severity: major Keywords:
Cc:

Description

If you create a table and then use the table properties link to reduce borders to 0, once you move out of the table and hit the toggletable borders link it doesn't work. Selecting the table doesn't make any difference either

If the borders of the table are manually set to 0px in the html code the toggleborders works as it should

IE doesn't have the same problem

Change History (4)

comment:1 Changed 15 years ago by anonymous

  • Component changed from Plugin - Fullscreen to Xinha Core

comment:2 Changed 15 years ago by PeteBest

  • Resolution set to fixed
  • Status changed from new to closed

Big thanks to a friend who managed to track down the issue, just replace the toggleborders with the one included below and this should resolve this issue

HTMLArea.prototype._toggleBorders = function()
{

tables = this._doc.getElementsByTagName('TABLE');
if(tables.length != 0)

{

if(!this.borders)

{

name = "bordered";
this.borders = true;

}
else
{

name = "";
this.borders = false;

}
for (var ix=0;ix < tables.length;ix++)
{

if(this.borders)
{

flashing the display forces moz to listen (JB:18-04-2005)
if(HTMLArea.is_gecko)
{

tables[ix].style.display="none";
tables[ix].style.display="table";

}
HTMLArea._addClass(tables[ix], 'htmtableborders');

}
else
{

HTMLArea._removeClass(tables[ix], 'htmtableborders');

}

}

}
return true;

}

comment:3 Changed 15 years ago by niko

  • Priority changed from normal to high
  • Resolution fixed deleted
  • Severity changed from normal to major
  • Status changed from closed to reopened
  • Summary changed from Toggleborders is faulty with Mozilla to Patch: Toggleborders is faulty with Mozilla
  • Version set to 0.1

I'm repoening this as the patch has not yet been commited to svn.

comment:4 Changed 14 years ago by gogo

  • Resolution set to fixed
  • Status changed from reopened to closed

Applied in changeset:119 - interesting fix.

Note: See TracTickets for help on using tickets.