Ticket #102 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

Patch: Toggleborders is faulty with Mozilla

Reported by: anonymous Owned by: gogo
Priority: high Milestone:
Component: Xinha Core Version: 0.1
Severity: major Keywords:
Cc:

Description

If you create a table and then use the table properties link to reduce borders to 0, once you move out of the table and hit the toggletable borders link it doesn't work. Selecting the table doesn't make any difference either

If the borders of the table are manually set to 0px in the html code the toggleborders works as it should

IE doesn't have the same problem

Change History

Changed 8 years ago by anonymous

  • component changed from Plugin - Fullscreen to Xinha Core

Changed 8 years ago by PeteBest

  • status changed from new to closed
  • resolution set to fixed

Big thanks to a friend who managed to track down the issue, just replace the toggleborders with the one included below and this should resolve this issue

HTMLArea.prototype._toggleBorders = function() {

tables = this._doc.getElementsByTagName('TABLE'); if(tables.length != 0)

{

if(!this.borders)

{

name = "bordered"; this.borders = true;

} else {

name = ""; this.borders = false;

} for (var ix=0;ix < tables.length;ix++) {

if(this.borders) {

// flashing the display forces moz to listen (JB:18-04-2005) if(HTMLArea.is_gecko) {

tables[ix].style.display="none"; tables[ix].style.display="table";

} HTMLArea._addClass(tables[ix], 'htmtableborders');

} else {

HTMLArea._removeClass(tables[ix], 'htmtableborders');

}

}

} return true;

}

Changed 8 years ago by niko

  • status changed from closed to reopened
  • severity changed from normal to major
  • summary changed from Toggleborders is faulty with Mozilla to Patch: Toggleborders is faulty with Mozilla
  • priority changed from normal to high
  • version set to 0.1
  • resolution deleted

I'm repoening this as the patch has not yet been commited to svn.

Changed 8 years ago by gogo

  • status changed from reopened to closed
  • resolution set to fixed

Applied in changeset:119 - interesting fix.

Note: See TracTickets for help on using tickets.