Changeset 673

Timestamp:

01/18/07 23:29:44 (6 years ago)

Author:

ray

Message:

• Ticket #911 Background color does not work in Firefox
  
• Ticket #619 useCSS is deprecated for midas engine
  

Location:

trunk

Files:

• XinhaCore.js (modified) (4 diffs)
• functionsMozilla.js (modified) (1 diff)

trunk/XinhaCore.js

@@ -3669 +3669 @@
     return false;
   }
+
+  // backcolor only works with useCSS/styleWithCSS (see mozilla bug #279330 & Midas doc)
+  // and its also nicer as <font>
+  if ( Xinha.is_gecko )
+  {
+    try
+    {
+     editor._doc.execCommand('useCSS', false, false); // useCSS deprecated & replaced by styleWithCSS 
+     editor._doc.execCommand('styleWithCSS', false, true); 
+     
+    } catch (ex) {}
+  }
   
   var btn = editor._toolbarObjects[cmdID].element;
@@ -3683 +3695 @@
       initcolor = Xinha._colorToRgb(editor._doc.queryCommandValue("hilitecolor"));
     }
-    // @todo : useCSS is deprecated, see ticket #619
-    //[wymsy]: mozilla bug #279330 has been fixed, I don't think we need this any more
-  /*  if ( Xinha.is_gecko )
-    {
-      try
-      {
-     //   editor._doc.execCommand('useCSS', false, false); //switch on useCSS (mozilla bug #279330)
-      } catch (ex) {}
-    }*/
   }
   else
@@ -3725 +3728 @@
   this.focusEditor();
   cmdID = cmdID.toLowerCase();
-  // @todo : useCSS is deprecated, see ticket #619
+  // useCSS deprecated & replaced by styleWithCSS
   if ( Xinha.is_gecko )
   {
@@ -3731 +3734 @@
     {
       this._doc.execCommand('useCSS', false, true); //switch useCSS off (true=off)
+      this._doc.execCommand('styleWithCSS', false, false); //switch styleWithCSS off 
+      
     } catch (ex) {}
   }

trunk/functionsMozilla.js

@@ -335 +335 @@
   if ( typeof sel == 'undefined' )
   {
-    debugger;
     sel = this._getSelection();
   }