Changeset 527

Timestamp:

07/19/06 00:29:31 (7 years ago)

Author:

mokhet

Message:

enhance loadback function.
- callback function is now optional
- application scope of the callback function can be forced
- a Bonus object can be send to the callback function

for instance, when we were needed to do this :

var bonus = {foo:'bar'};
var editor = this;
HTMLArea._loadback('a_file.js', function() { editor.myCallback(bonus); });

we now do this instead :

var bonus = {foo:'bar'};
HTMLArea._loadback('a_file.js', this.myCallback, this, bonus );

Files:

• trunk/htmlarea.js (modified) (5 diffs)

trunk/htmlarea.js

@@ -1420 +1420 @@
   if ( typeof Dialog == 'undefined' )
   {
-    // why can't we use the following line instead ?
-//    HTMLArea._loadback(_editor_url + 'dialog.js', this.generate );
-    HTMLArea._loadback(_editor_url + 'dialog.js', function() { editor.generate(); } );
+    HTMLArea._loadback(_editor_url + 'dialog.js', this.generate, this );
     return false;
   }
@@ -1428 +1426 @@
   if ( typeof HTMLArea.Dialog == 'undefined' )
   {
-    // why can't we use the following line instead ?
-//    HTMLArea._loadback(_editor_url + 'inline-dialog.js', this.generate );
-    HTMLArea._loadback(_editor_url + 'inline-dialog.js', function() { editor.generate(); } );
+    HTMLArea._loadback(_editor_url + 'inline-dialog.js', this.generate, this );
     return false;
   }
@@ -1436 +1432 @@
   if ( typeof PopupWin == 'undefined' )
   {
-    // why can't we use the following line instead ?
-//    HTMLArea._loadback(_editor_url + 'ipopupwin.js', this.generate );
-    HTMLArea._loadback(_editor_url + 'popupwin.js', function() { editor.generate(); } );
+    HTMLArea._loadback(_editor_url + 'popupwin.js', this.generate, this );
     return false;
   }
@@ -2480 +2474 @@
   var plugin_file = dir + "/" + plugin;
 
-  if ( callback )
-  {
-    HTMLArea._loadback(plugin_file, function() { callback(pluginName); });
-  }
-  else
-  {
-    /**
-    * @todo : try to avoid the use of document.write, it's evil
-    * @todo : better yet, try to update HTMLArea._loadback to let it include
-    *         the file without a callback function
-    *  try
-    *  {
-    *    var head = document.getElementsByTagName('head')[0];
-    *    var script = document.createElement('script');
-    *    script.type = "text/javascript";
-    *    script.src = plugin_file;
-    *    head.appendChild(script);
-    *  }
-    *  catch(ex)
-    *  {
-    *    document.write('<script type="text/javascript" src="' + plugin_file + '"></script>');
-    *  }
-    */
-    document.write('<script type="text/javascript" src="' + plugin_file + '"></script>');
-  }
+  HTMLArea._loadback(plugin_file, callback ? function() { callback(pluginName); } : null);
   return false;
 };
@@ -6471 +6441 @@
 };
 
-
-HTMLArea._loadback = function(src, callback)
-{
-  var head = document.getElementsByTagName("head")[0];
-  var evt = HTMLArea.is_ie ? "onreadystatechange" : "onload";
-
-  var script = document.createElement("script");
-  script.type = "text/javascript";
-  script.src = src;
-  script[evt] = function()
-  {
-    if ( HTMLArea.is_ie && ! ( /loaded|complete/.test(window.event.srcElement.readyState) ) )
-    {
-      return;
-    }
-    callback();
-  };
-  head.appendChild(script);
+/**
+ * Load a javascript file by inserting it in the HEAD tag and eventually call a function when loaded
+ * @param {string} U (Url)      Source url of the file to load
+ * @param {object} C {Callback} Callback function to launch once ready (optional)
+ * @param {object} O (scOpe)    Application scope for the callback function (optional)
+ * @param {object} B (Bonus}    Arbitrary object send as a param to the callback function (optional)
+ * @public
+ */
+HTMLArea._loadback = function(U, C, O, B)
+{
+  var S = document.createElement("script");
+  S.type = "text/javascript";
+  S.src = U;
+  if ( C )
+  {
+    S[HTMLArea.is_ie ? "onreadystatechange" : "onload"] = function()
+    {
+      if ( HTMLArea.is_ie && ! ( /loaded|complete/.test(window.event.srcElement.readyState) ) )
+      {
+        return;
+      }
+      C.call(O ? O : this, B);
+    };
+  }
+  document.getElementsByTagName("head")[0].appendChild(S);
 };