Changeset 254

Timestamp:

07/05/05 15:59:21 (8 years ago)

Author:

gocher

Message:

Workaround for removeAttribute() and setAttribute()
problems with IE

for Example

object.setAttribute("readOnly",true) in IE

object.setAttribute("readOnly","readOnly") in Mozilla

Location:

trunk/plugins/Forms

Files:

• forms.js (modified) (9 diffs)
• popups/fieldset.html (modified) (3 diffs)
• popups/input.html (modified) (5 diffs)
• popups/select.html (modified) (3 diffs)
• popups/textarea.html (modified) (5 diffs)

trunk/plugins/Forms/forms.js

@@ -85 +85 @@
                 this.value = value;
         }
-  function setAttr(el, attr, value) {
-    if (value != "")
-      el.setAttribute(attr, value);
-    else
-      el.removeAttribute(attr);
-  }
   var outparam = new Object();
   var type = button_id;
@@ -145 +139 @@
                   node = editor.getParentElement();
                   var tag = node.tagName.toLowerCase()
+      if (node && (tag == "legend")) {
+        node = node.parentElement;
+        tag = node.tagName.toLowerCase();
+      }
                   if (node && !(tag == "textarea" || tag == "select" || tag == "input" || tag == "label" || tag == "fieldset"))
                           node = null;
@@ -161 +159 @@
                   outparam.f_cols = node.cols;
                                   outparam.f_rows = node.rows;
-                                  outparam.f_value = node.innerHTML;
+                                  outparam.f_text = node.innerHTML;
           outparam.f_wrap = node.getAttribute("wrap");
-          outparam.f_readonly = node.getAttribute("readonly");
+          outparam.f_readOnly = node.getAttribute("readOnly");
           outparam.f_disabled = node.getAttribute("disabled");
           outparam.f_tabindex = node.getAttribute("tabindex");
@@ -183 +181 @@
                                   outparam.f_value = node.value;
                                         outparam.f_size = node.size;
-                                        outparam.f_maxlength = node.maxLength;
-          outparam.f_readonly = node.getAttribute("readonly");
+                                        outparam.f_maxLength = node.maxLength;
+          outparam.f_readOnly = node.getAttribute("readOnly");
           outparam.f_disabled = node.getAttribute("disabled");
           outparam.f_tabindex = node.getAttribute("tabindex");
@@ -233 +231 @@
         case "fieldset":
           if(node.firstChild.tagName.toLowerCase()=="legend")
-            outparam.f_legend = node.firstChild.innerHTML;
+            outparam.f_text = node.firstChild.innerHTML;
           else
-            outparam.f_legend = "";
+            outparam.f_text = "";
           break;
       }    
@@ -258 +256 @@
         outparam.f_value = "";
                   outparam.f_size = "";
-                  outparam.f_maxlength = "";
+                  outparam.f_maxLength = "";
                   outparam.f_checked = "";
                   outparam.f_src = "";
                   outparam.f_onclick = "";
       outparam.f_wrap = "";
-      outparam.f_readonly = "false";
+      outparam.f_readOnly = "false";
       outparam.f_disabled = "false";
       outparam.f_tabindex = "";
@@ -273 +271 @@
         editor._popupDialog("plugin://Forms/" + tagName + ".html", function(param) {
                 if (param) {
+        if(param["f_cols"])
+          if (isNaN(parseInt(param["f_cols"],10)) || parseInt(param["f_cols"],10) <= 0)
+            param["f_cols"] = "";
+        if(param["f_rows"])
+          if(isNaN(parseInt(param["f_rows"],10)) || parseInt(param["f_rows"],10) <= 0)
+            param["f_rows"] = "";
+        if(param["f_size"])
+          if(isNaN(parseInt(param["f_size"],10)) || parseInt(param["f_size"],10) <= 0)
+            param["f_size"] = "";
+        if(param["f_maxlength"])
+          if(isNaN(parseInt(param["f_maxLength"],10)) || parseInt(param["f_maxLength"],10) <= 0)
+            param["f_maxLength"] = "";
                         if(node) {
-                            //node.name = param["f_name"];
-          setAttr(node, "name", param["f_name"]);
+          //prepare existing Element
+          for (field in param) {
+            alert(field.substring(2,20) + '=' + param[field]);
+                                          if ((field=="f_text") || (field=="f_options") || (field=="f_onclick") || (field=="f_checked"))continue;
+            if (param[field] != "")
+              node.setAttribute(field.substring(2,20), param[field]);
+            else
+              node.removeAttribute(field.substring(2,20));
+                                  }
                             if (type == "textarea") {
-            if (isNaN(parseInt(param["f_cols"],10)) || parseInt(param["f_cols"],10) <= 0)
-              param["f_cols"] = "";
-            setAttr(node, "cols", param["f_cols"]);
-            if(isNaN(parseInt(param["f_rows"],10)) || parseInt(param["f_rows"],10) <= 0)
-              param["f_rows"] = "";
-                                          setAttr(node, "rows", param["f_rows"]);
-                                    setAttr(node, "value", param["f_value"]); //for ta in editor
-            setAttr(node, "wrap", param["f_wrap"]);
-            setAttr(node, "tabindex", param["f_tabindex"]);
-            setAttr(node, "accesskey", param["f_accesskey"]);
-            setAttr(node, "readonly", param["f_readonly"]);
-            setAttr(node, "disabled", param["f_disabled"]);
-            node.innerHTML = param["f_value"]; //for ta on web page
+            node.innerHTML = param["f_text"];
                             } else if(type == "select") {
-                                    if(isNaN(parseInt(param["f_size"],10)) || parseInt(param["f_size"],10) <= 0)
-              param["f_size"] = "";
-            setAttr(node, "size", param["f_size"]);
-                                          setAttr(node, "multiple" ,param["f_multiple"]);
-            setAttr(node, "disabled", param["f_disabled"]);
-            setAttr(node, "tabindex", param["f_tabindex"]);
-            node.options.length = 0;
+                                    node.options.length = 0;
                                     var optionsList =  param["f_options"];
                                     for (i=0; i<= optionsList.length-1; i++) {
@@ -303 +302 @@
                                     }
                             } else if(type == "label") {
-                                    setAttr(node, "for", param["f_for"]);
-                                          setAttr(node, "accesskey" ,param["f_accesskey"]);
-            node.innerHTML = param["f_text"];
+                                    node.innerHTML = param["f_text"];
           } else if(type == "fieldset") {
-            if(outparam.f_legend != "")
+            if(outparam.f_text != "") {
                                       if(node.firstChild.tagName.toLowerCase()=="legend")
-                node.firstChild.innerHTML = param["f_legend"];
-              else {
-                // not implemented jet
-              }
-          } else {  //type == "input"
-                                    for (field in param) {
-                                            switch (field) {
-                case "f_tabindex": setAttr(node, "tabindex", param["f_tabindex"]); break;
-                case "f_accesskey": setAttr(node, "accesskey", param["f_accesskey"]); break;
-                case "f_readonly": setAttr(node, "readonly", param["f_readonly"]); break;
-                case "f_disabled": setAttr(node, "disabled", param["f_disabled"]); break;
-                                                    case "f_type": node.type = param["f_type"]; break;
-                                                    case "f_value": setAttr(node,"value", param["f_value"]); break;
-                                                    case "f_size": 
-                                                            if(isNaN(parseInt(param["f_size"],10)) || parseInt(param["f_size"],10) <= 0)
-                    param["f_size"] = "";
-                                                                  setAttr(node, "size", param["f_size"]); break;
-                                                    case "f_maxlength":
-                                                            if(isNaN(parseInt(param["f_maxlength"],10)) || parseInt(param["f_maxlength"],10) <= 0)
-                    param["f_maxlength"] = "";
-                                                                  setAttr(node, "maxLength", param["f_maxlength"]); break;
-                                                    case "f_checked": setAttr(node, "checked", param["f_checked"]); break;
-                                                    case "f_src": setAttr(node, "src", param["f_src"]); break;
-                                                    case "f_onclick": setAttr(node, "onclick", param["f_onclick"]); 
-                     node.onclick = "";
-                                                               if(param["f_onclick"]!="") {
-                                                                       node.onclick = param["f_onclick"];
-                                                               } break;
-                                            }
-                                    }
+                node.firstChild.innerHTML = param["f_text"];
+            } else {}// not implemented jet
+          } else if((type == "checkbox") || (type == "radio")) { //input
+              if(param["f_checked"]!="")
+                                                    node.checked = true;
+              else
+                node.checked = false;
+          } else {
+            if(param["f_onclick"]){
+                                      node.onclick = "";
+                                            if(param["f_onclick"]!="") 
+                                                    node.onclick = param["f_onclick"];
+            }
                             }
         } else {
+          //create Element
+          var text = "";
+          for (field in param) {
+                                          if (!param[field]) continue;
+            if ((param[field]=="") || (field=="f_text")|| (field=="f_options"))continue;
+            text += " " + field.substring(2,20) + '="' + param[field] + '"';
+                                  }
+
                             if(type == "textarea") {
-                                    text = '<textarea name="' + param["f_name"] + '"' +
-                                                    ' cols="' + param["f_cols"] + '"' +
-                                                  ' rows="' + param["f_rows"] + '"';
-            if (param["f_wrap"] != "") text += ' wrap="' + param["f_wrap"] + '"';
-            if (param["f_tabindex"] != "") text += ' tabindex="' + param["f_tabindex"] + '"';
-            if (param["f_accesskey"] != "") text += ' accesskey="' + param["f_accesskey"] + '"';
-            if (param["f_readonly"] == "true") text += ' readonly="true"'; //don't know why ="true"
-            if (param["f_disabled"] == "true") text += ' disabled="true"'; //don't know why ="true"
-            text += '>' + param["f_value"] + '</textarea>';
+                                    text = '<textarea' + text + '>' + param["f_text"] + '</textarea>';
                             } else if(type == "select") {
-                                    text = '<select name="'+param["f_name"]+'"';
-                                    if (param["f_size"]) text += ' size="'+parseInt(param["f_size"],10)+'"';
-                                    if (param["f_tabindex"] != "") text += ' tabindex="' + param["f_tabindex"] + '"';
-            if (param["f_multiple"] == "true") text += ' multiple="true"'; //don't know why ="true"
-            if (param["f_disabled"] == "true") text += ' disabled="true"'; //don't know why ="true"
-                                    text += '>';
+                                    text = '<select' + text + '>';
                                     var optionsList =  param["f_options"];
                                     for (i=0; i<= optionsList.length-1; i++) {
@@ -364 +339 @@
                                     text += '</select>';
           } else if(type == "label") {
-            text = '<label';
-            if (param["f_for"] != "") text += ' for="'+param["f_for"]+'"';
-            if (param["f_accesskey"] != "") text += ' accesskey="' + param["f_accesskey"] + '"';                                          
-            text += '>' + param["f_text"] + '</label>';
+            text = '<label' + text + '>' + param["f_text"] + '</label>';
           } else if(type == "fieldset") {
-            text = '<fieldset>';
-            if (param["f_legend"] != "") text += '<legend>' + param["f_legend"] + '</legend>';
+            text = '<fieldset' + text + '>';
+            if (param["f_legend"] != "") text += '<legend>' + param["f_text"] + '</legend>';
                                     text += '</fieldset>';
                             } else {
-                                    text = '<input type="'+type+'"' +
-                                           ' name="'+param["f_name"]+'"';
-                                    for (field in param) {
-                                            var value = param[field];
-                                            if (!value) continue;
-                                            switch (field) {
-                                                    case "f_value": if (param["f_value"] != "") text += ' value="'+param["f_value"]+'"'; break;
-                                                    case "f_size": if (param["f_size"] != "") text += ' size="'+parseInt(param["f_size"],10)+'"'; break;
-                                                    case "f_maxlength": if (param["f_maxlength"] != "") text += ' maxlength="'+parseInt(param["f_maxlength"],10)+'"'; break;
-                                                    case "f_checked": if (param["f_checked"] == "true") text += ' checked'; break;
-                                                    case "f_src": if (param["f_src"] != "") text += ' src="'+param["f_src"]+'"'; break;
-                                                    case "f_onclick": if (param["f_onclick"] != "") text += ' onClick="'+param["f_onclick"]+'"'; break;
-                case "f_tabindex": if (param["f_tabindex"] != "") text += ' tabindex="'+param["f_tabindex"]+'"'; break;
-                case "f_accesskey": if (param["f_accesskey"] != "") text += ' accesskey="'+param["f_accesskey"]+'"';
-                case "f_readonly": if (param["f_readonly"] == "true") text += ' readonly="true"'; //don't know why ="true"
-                case "f_disabled": if (param["f_disabled"] == "true") text += ' disabled="true"'; break;//don't know why ="true"
-                                            }
-                                    }
-                                    text += '>';
+                                    text = '<input type="'+type+'"' + text + '>';
                             }
                 editor.insertHTML(text);

trunk/plugins/Forms/popups/fieldset.html

@@ -12 +12 @@
         __dlg_init();
         var param = window.dialogArguments;
-  document.getElementById("f_legend").value = param["f_legend"];
-  document.getElementById("f_legend").focus();
+  document.getElementById("f_text").value = param["f_text"];
+  document.getElementById("f_text").focus();
 };
 
@@ -19 +19 @@
         // pass data back to the calling window
   var param = new Object();
-  param["f_legend"] = document.getElementById("f_legend").value;
+  param["f_text"] = document.getElementById("f_text").value;
         __dlg_close(param);
   return false;
@@ -36 +36 @@
   <form action="" method="get">
     <div class="fr">Legend:</div>
-    <input type="text" name="legend" id="f_legend" />
+    <input type="text" name="text" id="f_text" />
     <p />
     <div id="buttons">

trunk/plugins/Forms/popups/input.html

@@ -22 +22 @@
     case "text":
     case "password":
-      fields = ["f_name", "f_value", "f_readonly", "f_disabled", "f_tabindex", "f_accesskey", "f_size"];
+      fields = ["f_name", "f_value", "f_readOnly", "f_disabled", "f_tabindex", "f_accesskey", "f_size", "f_maxLength"];
       height = 350;
       document.getElementById("txt").style.display = "block";
@@ -63 +63 @@
   for (var i in fields) {
     switch (fields[i]) { 
-    case "f_readonly": 
+    case "f_readOnly": 
     case "f_disabled":
     case "f_checked":
-      document.getElementById(fields[i]).checked = param[fields[i]]=="true"; break;
+      document.getElementById(fields[i]).checked = (param[fields[i]]==fields[i].substring(2,20)) || (param[fields[i]] == true); break;
     default:
       document.getElementById(fields[i]).value = param[fields[i]]; break;
@@ -84 +84 @@
   // pass data back to the calling window
   var param = new Object();
-  param["f_type"] = type;
   for (var i in fields) {
     switch (fields[i]) {
-    case "f_readonly":
+    case "f_readOnly":
     case "f_disabled":
     case "f_checked":
-      param[fields[i]] = (document.getElementById(fields[i]).checked)?"true":""; break;
+      if(HTMLArea.is_ie)
+        param[fields[i]] = (document.getElementById(fields[i]).checked)?true:"";
+      else
+        param[fields[i]] = (document.getElementById(fields[i]).checked)?fields[i].substring(2,20):"";
+      break;
     default:
       param[fields[i]] = document.getElementById(fields[i]).value; break;
@@ -149 +152 @@
   <div id="txt">
     <div class="fr">Read Only</div>
-    <input type="checkbox" name="readonly" id="f_readonly" value="readonly" />
+    <input type="checkbox" name="readOnly" id="f_readOnly" value="readOnly" />
     <p />
     
@@ -159 +162 @@
       <div class="space"></div>
       <div class="fr">Max length:</div>
-      <input type="text" name="maxlength" id="f_maxlength" size="5"     title="Maximum number of characters accepted" />
+      <input type="text" name="maxLength" id="f_maxLength" size="5"     title="Maximum number of characters accepted" />
       <div class="space"></div>
           </fieldset>

trunk/plugins/Forms/popups/select.html

@@ -18 +18 @@
     case "f_multiple":
     case "f_disabled":
-      document.getElementById(fields[i]).checked = param[fields[i]] == "true"; break;
+      document.getElementById(fields[i]).checked = (param[fields[i]]==fields[i].substring(2,20)) || (param[fields[i]] == true); break;
     case "f_size":
       document.getElementById(fields[i]).value = (param[fields[i]]<=0)?"":param[fields[i]]; break;
@@ -46 +46 @@
         param["f_multiple"] = "";
       else
-            param["f_multiple"] = (document.getElementById(fields[i]).checked)?"true":"";
+            param["f_multiple"] = (document.getElementById(fields[i]).checked)?"multiple":"";
             break;
     case "f_disabled":
-      param[fields[i]] = (document.getElementById(fields[i]).checked)?"true":""; break;
+      param[fields[i]] = (document.getElementById(fields[i]).checked)?"disabled":""; break;
     default:
       param[fields[i]] = document.getElementById(fields[i]).value; break;
@@ -163 +163 @@
     <p />
     <div class="fr">Size:</div>
-    <input name="size" id="f_size" type="text" value="" size="15">
+    <input name="size" id="f_size" type="text" value="" size="15" />
     <p />
                 <div class="fr"><nobr>Multiple Select</nobr></div>
-    <input name="multiple" id="f_multiple" type="checkbox">
+    <input name="multiple" id="f_multiple" type="checkbox" value="multiple" />
     <p />
     <div class="fr">Disabled</div>

trunk/plugins/Forms/popups/textarea.html

@@ -8 +8 @@
 <script type="text/javascript">
 
-var fields = ["f_name", "f_value", "f_cols", "f_rows", "f_wrap", "f_tabindex", "f_accesskey", "f_readonly", "f_disabled"];
+var fields = ["f_name", "f_text", "f_cols", "f_rows", "f_wrap", "f_tabindex", "f_accesskey", "f_readOnly", "f_disabled"];
 
 function Init() {
-  window.resizeTo(480,260);
+  window.resizeTo(280,260);
   __dlg_translate("Forms");
         __dlg_init();
@@ -17 +17 @@
   for (var i in fields) {
     switch (fields[i]) { 
-    case "f_readonly": 
+    case "f_readOnly":
     case "f_disabled":
-      document.getElementById(fields[i]).checked = param[fields[i]]=="true"; break;
+      document.getElementById(fields[i]).checked = (param[fields[i]]==fields[i].substring(2,20)) || (param[fields[i]] == true);  break;
     default:
       document.getElementById(fields[i]).value = param[fields[i]]; break;
@@ -38 +38 @@
   for (var i in fields) {
     switch (fields[i]) { 
-    case "f_readonly": 
+    case "f_readOnly":
     case "f_disabled":
-      param[fields[i]] = (document.getElementById(fields[i]).checked)?"true":""; break;
+      if(HTMLArea.is_ie)
+        param[fields[i]] = (document.getElementById(fields[i]).checked)?true:"";
+      else
+        param[fields[i]] = (document.getElementById(fields[i]).checked)?fields[i].substring(2,20):"";
+      break;
     default:
       param[fields[i]] = document.getElementById(fields[i]).value; break;
@@ -86 +90 @@
   <p />
   <div class="fr">Read Only</div>
-  <input type="checkbox" name="readonly" id="f_readonly" value="readonly" />
+  <input type="checkbox" name="readOnly" id="f_readOnly" value="readOnly" />
   <p />
   <div class="fr">Disabled</div>
@@ -99 +103 @@
   
   <div class="fr">Initial Text:</div>
-  <input type="text" name="value" id="f_value" title="Default text (optional)" />
+  <input type="text" name="text" id="f_text" title="Default text (optional)" />
   <div id="buttons">
     <button type="button" name="ok" onclick="return onOK();">OK</button>