Ignore:
Timestamp:
04/01/11 14:24:09 (8 years ago)
Author:
gogo
Message:

Updates to http://www.github.com/sleemanj/mootools-filemanager from GerHoblett?

http://www.github.com/GerHoblett/

Changes to said updates by gogo (sleemanj @ github)

Modifications to MootoolsFileManager? to work with those updates, some courtesy of GerHoblett?, some sleemanj

GerHoblett? provided a large diff which accomplished the goal in a quite different way. It has merit, however I have opted for a less-affecting path in so far as Xinha's "way" is concerned, namely, not splitting the config for a single plugin into several calls to backend config passing functions which seemed a little cumbersome.

Instead I take the option of using POST to send backend data around, at the minor expense of an extra round trip when displaying thumbnails (for each one). This could be reduced by checking for thumbnail existence and returning the thumbnail name directly in "onView" rather than the backend request to generate said thumbnail.

Still to do, is to make the preview pane thumbnail also work.


File:
1 edited

Legend:

Unmodified
Added
Removed
  • branches/MootoolsFileManager-Update/plugins/MootoolsFileManager/mootools-filemanager/Assets/Connector/Assets/getid3/module.tag.xmp.php

    r1300 r1302  
    152152 
    153153                                // Read the segment data with length indicated by the previously read size 
    154                                 $segdata = fread($filehnd, $decodedsize['size'] - 2); 
     154                                if ($decodedsize['size'] - 2 > 0)       // [i_a] bugfix 
     155                                { 
     156                                        $segdata = fread($filehnd, $decodedsize['size'] - 2); 
     157                                } 
     158                                else 
     159                                { 
     160                                        $segdata = null; 
     161                                } 
    155162 
    156163                                // Store the segment information in the output array 
     
    334341                                                { 
    335342                                                        // If Lang Alt (language alternatives) then ensure we take the default language 
    336                                                         if ($xml_elem['attributes']['xml:lang'] != 'x-default') 
     343                                                        if (empty($xml_elem['attributes']['xml:lang']) || $xml_elem['attributes']['xml:lang'] != 'x-default')  // [i_a] crash fix 
    337344                                                        { 
    338345                                                                break; 
    339346                                                        } 
    340347                                                } 
    341                                                 if ($current_property != '') 
     348                                                if ($current_property != '' && isset($xml_elem['value']))  // [i_a] 
    342349                                                { 
    343350                                                        $xmp_array[$current_property][$container_index] = $xml_elem['value']; 
Note: See TracChangeset for help on using the changeset viewer.