Ignore:
Timestamp:
04/01/11 14:24:09 (9 years ago)
Author:
gogo
Message:

Updates to http://www.github.com/sleemanj/mootools-filemanager from GerHoblett?

http://www.github.com/GerHoblett/

Changes to said updates by gogo (sleemanj @ github)

Modifications to MootoolsFileManager? to work with those updates, some courtesy of GerHoblett?, some sleemanj

GerHoblett? provided a large diff which accomplished the goal in a quite different way. It has merit, however I have opted for a less-affecting path in so far as Xinha's "way" is concerned, namely, not splitting the config for a single plugin into several calls to backend config passing functions which seemed a little cumbersome.

Instead I take the option of using POST to send backend data around, at the minor expense of an extra round trip when displaying thumbnails (for each one). This could be reduced by checking for thumbnail existence and returning the thumbnail name directly in "onView" rather than the backend request to generate said thumbnail.

Still to do, is to make the preview pane thumbnail also work.


File:
1 edited

Legend:

Unmodified
Added
Removed
  • branches/MootoolsFileManager-Update/plugins/MootoolsFileManager/mootools-filemanager/Assets/Connector/Assets/getid3/getid3.php

    r1300 r1302  
    11881188                                foreach ($this->info[$comment_name]['comments'] as $tag_key => $valuearray) { 
    11891189                                        foreach ($valuearray as $key => $value) { 
    1190                                                 $value = (is_string($value) ? trim($value) : $value); 
     1190                                                // $value = (is_string($value) ? trim($value) : $value);     // [i_a] http://www.getid3.org/phpBB3/viewtopic.php?f=4&t=1136 
    11911191                                                if (!empty($value) > 0) { 
    11921192                                                        $this->info['tags'][trim($tag_name)][trim($tag_key)][] = $value; // do not trim!! Unicode characters will get mangled if trailing nulls are removed! 
Note: See TracChangeset for help on using the changeset viewer.