Changeset 1097 for trunk/plugins/Linker/dialog.html

Timestamp:

10/20/08 15:53:08 (5 years ago)

Author:

nicholasbs

Message:

* Fixes #58 (configuration of allowed target types)
* Fixes #1308 (remove link button doesn't work, switching target types causes JS error)
* Clean up dialog html (remove embedded JavaScript?)

Files:

• trunk/plugins/Linker/dialog.html (modified) (4 diffs)

trunk/plugins/Linker/dialog.html

@@ -4 +4 @@
 <div id="[options]" >
   <fieldset>
-    <legend><label><input type="radio" name="[type]" id="[type]" value="url" checked="checked" onclick="
-      document.getElementById('[urltable]').style.display=this.checked?'':'none';
-      document.getElementById('[mailtable]').style.display=this.checked?'none':'';
-      document.getElementById('[anchortable]').style.display=this.checked?'none':'';
-    " /> <l10n>URL Link</l10n></label></legend>
+    <legend><label><input type="radio" name="[type]" id="[type_url]" value="url" checked="checked" />
+        <l10n>URL Link</l10n>
+    </label></legend>
     <table id="[urltable]" width="100%">
       <tr>
         <th><label for="[href]"><l10n>URL:</l10n> </label></th>
-        <td><input type="text" name="[href]" style="width:100%" value="http://www.example.com/" onfocus="if (this.value == 'http://www.example.com/') this.value = '';" /></td>
+        <td><input type="text" name="[href]" id="[href]" style="width:100%" value="http://www.example.com/" onfocus="if (this.value == 'http://www.example.com/') this.value = '';" /></td>
       </tr>
-      <tr style="vertical-align: top;">
+      <tr style="vertical-align: top;" id="[target_options]">
         <th><l10n>Target:</l10n></th>
         <td>
-          <div><label><input type="radio" name="[target]" value="" onclick="document.getElementById('[popuptable]').style.display='none';"  checked="checked" /> <l10n>Ordinary Link</l10n></label></div>
-          <div><label><input type="radio" name="[target]" value="_top" onclick="document.getElementById('[popuptable]').style.display='none';"   /> <l10n>Same Window (jump out of frames)</l10n></label></div>
-          <div><label><input type="radio" name="[target]" value="_blank" onclick="document.getElementById('[popuptable]').style.display='none';"/> <l10n>New Window</l10n> </label></div>
-          <div>
-            <label><input type="radio" name="[target]" value="popup"    onclick="document.getElementById('[popuptable]').style.display='';" /> <l10n>Popup Window</l10n> </label>
+          <div id="[noTarget]"><label><input type="radio" name="[target]" id="[noTargetRadio]" value="" /> <l10n>Ordinary Link</l10n></label></div>
+          <div id="[sameWindow]"><label><input type="radio" name="[target]" id="[sameWindowRadio]" value="_top" /> <l10n>Same Window (jump out of frames)</l10n></label></div>
+          <div id="[newWindow]"><label><input type="radio" name="[target]" id="[newWindowRadio]" value="_blank" /> <l10n>New Window</l10n> </label></div>
+          <div id="[popupWindow]">
+            <label><input type="radio" name="[target]" id="[popupWindowRadio]" value="popup" /> <l10n>Popup Window</l10n> </label>
              <div style="padding-left:10px">
               <table id="[popuptable]">
@@ -61 +59 @@
   </fieldset>
   <fieldset id="[mailtofieldset]">
-    <legend><label><input type="radio" name="[type]" value="mailto" onclick="
-      document.getElementById('[mailtable]').style.display=this.checked?'':'none';
-      document.getElementById('[urltable]').style.display=this.checked?'none':'';
-      document.getElementById('[anchortable]').style.display=this.checked?'none':'';
-    "/> <l10n>Email Link</l10n></label></legend>
+    <legend><label><input type="radio" name="[type]" id="[type_mailto]" value="mailto"/>
+        <l10n>Email Link</l10n>
+    </label></legend>
     <table id="[mailtable]" width="100%">
       <tr>
         <th><label for="[to]"><l10n>Email Address:</l10n> </label></th>
-        <td><input type="text" name="[to]" style="width:100%" value="alice@example.com" onfocus="if (this.value == 'alice@example.com') this.value = '';" /></td>
+        <td><input type="text" name="[to]" id="[to]" style="width:100%" value="alice@example.com" onfocus="if (this.value == 'alice@example.com') this.value = '';" /></td>
       </tr>
       <tr>
@@ -83 +79 @@
 
   <fieldset id="[anchorfieldset]">
-    <legend><label><input type="radio" name="[type]" value="anchor" onclick="
-      document.getElementById('[urltable]').style.display=this.checked?'none':'';
-      document.getElementById('[mailtable]').style.display=this.checked?'none':'';
-      document.getElementById('[anchortable]').style.display=this.checked?'':'none';
-    "/> <l10n>Anchor-Link</l10n></label></legend>
+    <legend><label><input type="radio" name="[type]" id="[type_anchor]" value="anchor"/>
+        <l10n>Anchor-Link</l10n>
+    </label></legend>
     <table id="[anchortable]" width="100%">
       <tr>
@@ -101 +95 @@
   <div style="text-align:right">
     <input type="button" id="[ok]"     value="_(OK)"     />
-    <input type="button" id="[clear]"  value="_(Remove Link)" onclick="this.form['[href]'].value='';this.form['[to]'].value='';document.getElementById('[ok]').click();" />
+    <input type="button" id="[clear]"  value="_(Remove Link)" />
     <input type="button" id="[cancel]" value="_(Cancel)" />
   </div>
 </div>
 </div>
+
+