Changeset 1088

Timestamp:

10/13/08 21:06:08 (5 years ago)

Author:

douglas

Message:

FIXED Ticket #1304 getElementsByName now uses the Xinha function collectionToArray, which was updated with the speed trick from getElementsByName

Location:

trunk

Files:

• XinhaCore.js (modified) (1 diff)
• modules/Dialogs/XinhaDialog.js (modified) (1 diff)

trunk/XinhaCore.js

@@ -6515 +6515 @@
 Xinha.collectionToArray = function(collection)
 {
+  try
+  {
+    return collection.length ? Array.prototype.slice.call(collection) : []; //Collection to Array
+  }
+  catch(e)
+  {
+    // In certain implementations (*cough* IE), you can't call slice on a
+    // collection.  We'll fallback to using the simple, non-native iterative
+    // approach.
+  }
+
   var array = [ ];
   for ( var i = 0; i < collection.length; i++ )

trunk/modules/Dialogs/XinhaDialog.js

@@ -529 +529 @@
 {
   var els = this.document.getElementsByName(this.id[name] ? this.id[name] : name); 
-  return els.length ? Array.prototype.slice.call(els) : []; //Collection to Array
+  return Xinha.collectionToArray(els);
 };
 /** Return all elements in the dialog that have the given class