Changeset 1019 for branches/new-dialogs

Timestamp:

08/15/08 19:53:53 (11 years ago)

Author:

nicholasbs

Message:

Initial fix for ticket #1264

• option to close modal dialogs when escape key is pressed
• turned off modeless dialogs for the time being as their implementation is currently incomplete (see #1264 for discussion)

File:

• branches/new-dialogs/modules/Dialogs/XinhaDialog.js (modified) (3 diffs)

branches/new-dialogs/modules/Dialogs/XinhaDialog.js

@@ -43 +43 @@
   this.layer = (options && options.layer) ? options.layer : 0;
   this.centered = (options && options.centered === true) ? true : false;
-  
+  this.closeOnEscape = (options && options.closeOnEscape === true) ? true : false;
+
   /* Check global config to see if we should override any of the above options
     If a global option is set, it will apply to all dialogs, regardless of their
@@ -63 +64 @@
       this.modal = globalOptions.modal;
     }
-  }
+    if (typeof(globalOptions.closeOnEscape) != 'undefined') {
+      this.closeOnEscape = globalOptions.closeOnEscape;
+    }
+  }
+
+  /* NOTE: Support for modeless dialogs is incomplete and all current plugins
+  /* use modal dialogs, so I'm deactivating modeless dialogs until these issues are fixed
+  /* Outstanding issues with modeless dialogs:
+  /*   - it's possible new modeless dialogs will be opened behind other dialogs
+  /*   - there's no visual indication as to which modeless dialog is frontmost and has focus
+  /*   - closing one dialog does not cause the dialog behind it to gain focus
+  /*   - no active modeless dialog is set until one is clicked, i.e., none is set by just calling show()
+  /*   - you can type in a form field of a dialog even when it's not frontmost (and doing so doesn't activate it)
+  /* See discussion on ticket #1264: http://xinha.webfactional.com/ticket/1264
+  */
+  this.modal = true;
 
   if (Xinha.is_ie)
@@ -171 +187 @@
   }
   rootElem.appendChild(this.buttons);
-  
+
+  if (this.closeOnEscape)
+  {
+    Xinha._addEvent(document, 'keypress', function(ev) {
+      if (ev.keyCode == 27) // ESC key
+      {
+        if (Xinha.Dialog.activeModeless == dialog || dialog.modal)
+        {
+          dialog.hide();
+          return true;
+        }
+      }
+    });
+  }
+
   this.closer = null;
   if ( this.closable )